[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 3 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1491 +mapTypes = exitDataOp.getMapTypes(); +mapperFunc = false; +return success();

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

mehdi_amini added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1491 +mapTypes = exitDataOp.getMapTypes(); +mapperFunc = false; +return success(); This line is not needed

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond, processMapOpCB, bodyCB)); + } else {

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond, processMapOpCB, bodyCB)); + } else {

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

mehdi_amini added inline comments. Herald added a subscriber: bviyer. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d373e4dc7e9: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 506563. TIFitis added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1523 + auto bodyCB = [&](InsertPointTy allocaIP, InsertPointTy codeGenIP) { +// DataOp has only one region associated with it. +auto = cast(op).getRegion();

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 506054. TIFitis marked 5 inline comments as done. TIFitis added a comment. Addresed reviewer comments. Removed flang changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jplehr. LGTM. Please wait a day before submission. Move the flang portion to a separate commit. Comment at:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 505456. TIFitis marked an inline comment as done. TIFitis added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 505116. TIFitis added a comment. Herald added a project: Flang. Added TODO for unsupported map operand types in Flang frontend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase , LLVM::ModuleTranslation ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase , LLVM::ModuleTranslation ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added inline comments. Herald added a subscriber: sunshaoce. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase , LLVM::ModuleTranslation ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase , LLVM::ModuleTranslation ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 503741. TIFitis added a comment. Added names for offload mapper variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan requested changes to this revision. kiranchandramohan added inline comments. This revision now requires changes to proceed. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1561 + /// should be placed. + /// \param HasRegion True if the op has a region associated with it, false + /// otherwise kiranchandramohan wrote: > TIFitis wrote: > >

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 503137. TIFitis marked 3 inline comments as done. TIFitis added a comment. Addressed comments. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added a comment. Thanks for the update and the replies. See comments inline. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1561 + /// should be placed. + /// \param HasRegion True if the op has a region associated with it, false + ///

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1561 + /// should be placed. + /// \param HasRegion True if the op has a region associated with it, false + /// otherwise kiranchandramohan wrote: > Can't the

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 502670. TIFitis marked 9 inline comments as done. TIFitis added a comment. Adrresed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. I have some more comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1556 + /// Generator for '#omp target data' + ///

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4052-4060 + // LLVM utilities like blocks with terminators. + auto *UI = Builder.CreateUnreachable(); + Instruction *ThenTI = UI, *ElseTI = nullptr; + if (IfCond) { +

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 502175. TIFitis marked 7 inline comments as done. TIFitis added a comment. Addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Thanks for making the change. I am still going through the patch, I have a few comments. Comment at:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added a comment. @kiranchandramohan I've added the MLIR test as requested. Please let me know if any other changes are required :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 501842. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 500807. TIFitis added a comment. Added MLIR test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added a comment. In D142914#4145224 , @TIFitis wrote: > In D142914#4144475 , > @kiranchandramohan wrote: > >> Please add tests for the MLIR portion. > > Can you please tell me where to add

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 499583. TIFitis marked an inline comment as done. TIFitis added a comment. Addressed reviewer comments, fixed error in MLIR translation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 4 inline comments as done. TIFitis added a comment. In D142914#4144475 , @kiranchandramohan wrote: > Please add tests for the MLIR portion. Can you please tell me where to add these? > Could you also post the full LLVM IR for a

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Please add tests for the MLIR portion. Could you also post the full LLVM IR for a construct with the map clause? Comment at:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added a comment. @kiranchandramohan @clementval can you please take a look and let me know if any more changes are required for this patch? Thanks, Akash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

raghavendhra accepted this revision. raghavendhra added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 497045. TIFitis added a comment. Fixing build errors. Added mlir/lib/Target/LLVMIR/Dialect/Utils.cpp, made it part of the MLIRTargetLLVMIRExport lib. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 495864. TIFitis marked 5 inline comments as done. TIFitis added a comment. Addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

jdoerfert added a comment. Please avoid the MLIR style in any other subproject. I know some of the OpenMP Builder stuff already uses `llvm::` and MLIR style names, but that is in itself bad, not something we should extend. Comment at:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 495530. TIFitis edited the summary of this revision. TIFitis added a comment. Added explicit failure for use_device_ptr and use_device_addr clauses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 495493. TIFitis marked 4 inline comments as done. TIFitis added a comment. Changed namespace to mlir::LLVM for common files. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

ftynse added inline comments. Comment at: mlir/include/mlir/Target/LLVMIR/Dialect/Utils.h:27 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc, llvm::OpenMPIRBuilder ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

ftynse added inline comments. Comment at: mlir/include/mlir/Target/LLVMIR/Dialect/Utils.h:13 + +#ifndef MLIR_DIALECT_UTILS_H +#define MLIR_DIALECT_UTILS_H This tag is wrong. It should be `MLIR_TARGET_LLVMIR_DIALECT_UTILS_H`. Comment at:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant *

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added a comment. Please add more description to the summary regarding the scope of this patch. If it is only able to lower specific llvm-dialect types, please call out that. Please also explain the split in work between mlir::Translation and OpenMPIRbuilder. You can also

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant *

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant *

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant *

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 493615. TIFitis marked an inline comment as done. TIFitis added a comment. Added new header file mlir/include/mlir/Target/LLVMIR/Dialect/Utils.h, moved two common functions to the new file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant *

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 493549. TIFitis marked an inline comment as done. TIFitis added a comment. Moved getSizeInBytes to OMPIRBuilder.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant *

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added a subscriber: raghavendhra. kiranchandramohan added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis created this revision. TIFitis added reviewers: kiranchandramohan, clementval, jdoerfert. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,