This revision was automatically updated to reflect the committed changes.
Closed by commit rGd0db54e0dd32: [clang] Update test according to P1937
(authored by Fznamznon).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145362/new/
Fznamznon added inline comments.
Comment at: clang/test/CXX/expr/expr.const/p8-2a.cpp:14
-// bad_assert_copyable is not needed for constant evaluation
-// (and thus not instantiated)
+// consteval assert is not instantiated as well.
template consteval void assert_copyable() {
Fznamznon updated this revision to Diff 502742.
Fznamznon added a comment.
Rebase and apply the nitpick
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145362/new/
https://reviews.llvm.org/D145362
Files:
clang/test/CXX/expr/expr.const/p8-2a.cpp
shafik accepted this revision.
shafik added a comment.
Besides the nitpick, LGTM
Comment at: clang/test/CXX/expr/expr.const/p8-2a.cpp:14
-// bad_assert_copyable is not needed for constant evaluation
-// (and thus not instantiated)
+// consteval assert is not instantiated as
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for cleaning that test up!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145362/new/
Fznamznon created this revision.
Herald added a project: All.
Fznamznon requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
https://wg21.link/p1937 proposes that in unevaluated contexts, consteval
functions should not be immediately evaluated.