This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG61ed64954b97: [SanitizerBinaryMetadata] Do not add to GPU
code (authored by melver).
Repository:
rG LLVM Github Monorep
melver updated this revision to Diff 503326.
melver marked an inline comment as done.
melver added a comment.
Simplify assert.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145519/new/
https://reviews.llvm.org/D145519
Files:
clang/lib/Driver/San
tra added a comment.
LGTM for NVPTX.
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerBinaryMetadata.cpp:134
assert(TargetTriple.isOSBinFormatELF() && "ELF only");
+assert((!TargetTriple.isNVPTX() && !TargetTriple.isAMDGPU()) &&
+ "Device targets are
melver created this revision.
melver added a reviewer: dvyukov.
Herald added subscribers: Enna1, hiraditya.
Herald added a project: All.
melver requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, MaskRay.
Herald added projects: clang, LLVM.
SanitizerBinaryMetada
