[PATCH] D146054: [RISCV] Add --print-supported-extensions support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b40ced4e5ba: [RISCV] Add --print-supported-extensions support (authored by 4vtomat). Changed prior to commit: https://reviews.llvm.org/D146054?vs

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:4586 +def print_supported_extensions : Flag<["-", "--"], "print-supported-extensions">, + Group, Flags<[CC1Option, C

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 554609. 4vtomat added a comment. Resolved MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td clang/i

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added a comment. In D146054#4596571 , @MaskRay wrote: > In D146054#4587210 , @4vtomat wrote: > >> In D146054#4586067 , @MaskRay >> wrote: >> >>> I think the best

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added a comment. Herald added a subscriber: sunshaoce. In D146054#4587210 , @4vtomat wrote: > In D146054#4586067 , @MaskRay wrote: > >> I think the best place to test `RISCVISAInfo.cpp` is >> `llvm/unitte

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 550185. 4vtomat added a comment. 1. Apply clang-format for this patch 2. Replace FileCheck --implicit-check-not=warning: with %clang -Werror Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://rev

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat marked 2 inline comments as done. 4vtomat added a comment. In D146054#4586067 , @MaskRay wrote: > I think the best place to test `RISCVISAInfo.cpp` is > `llvm/unittests/Support/RISCVISAInfoTest.cpp`. > > `clang/test/Driver/print-supported-extensi

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added a comment. I think the best place to test `RISCVISAInfo.cpp` is `llvm/unittests/Support/RISCVISAInfoTest.cpp`. `clang/test/Driver/print-supported-extensions.c` can test just a few lines, so that changes to RISC-V extensions will generally not require updates to `clang/test/Driver

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545500. 4vtomat added a comment. Updated test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td clang/include/cla

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added inline comments. Comment at: clang/include/clang/Frontend/FrontendOptions.h:290 + /// Output time trace profile. + unsigned TimeTrace : 1; + MaskRay wrote: > stray change? Oh, maybe it was added accidentally during rebase lol~ C

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545499. 4vtomat marked 6 inline comments as done. 4vtomat added a comment. Resolved MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4340 +} + } no blank line here Comment at: clang/test/Driver/print-supported-extensions.c:93 +// CHECK-NEXT: xventanacondops 1.0 +// +// CHECK:Experimental e

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545412. 4vtomat added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td clang/include/clang/Frontend/

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545411. 4vtomat marked 6 inline comments as done. 4vtomat added a comment. Resolved MaskRay's comments, thanks for reviewing!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added a comment. Sorry for the delay. Comment at: clang/include/clang/Frontend/FrontendOptions.h:286 + /// print the supported extensions for the current target + unsigned PrintSupportedExtensions : 1; Comment at: clang/include/c

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat marked an inline comment as done. 4vtomat added a comment. @MaskRay if you are available, please help me to check the revision, thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 ___

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat marked an inline comment as done. 4vtomat added inline comments. Comment at: clang/test/Driver/print-supported-extensions.c:3 + +// REQUIRES: riscv-registered-target + MaskRay wrote: > If you remove `all` and `RISCV` from `LLVM_TARGETS_TO_BUILD`, you can

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added inline comments. Comment at: clang/test/Driver/print-supported-extensions.c:6 +// RUN: %clang --target=riscv64 --print-supported-extensions 2>&1 | \ +// RUN: FileCheck %s --check-prefix=CHECK-RISCV + MaskRay wrote: > MaskRay wrote: > > Use `--impl

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 536947. 4vtomat marked 27 inline comments as done. 4vtomat added a comment. Herald added a subscriber: wangpc. Sorry for late update. Resolved MaskRay's comments, thanks for detailed review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/print-supported-extensions.c:1 +// Test that --print-supported-extensions lists supported extensions. + Some ne

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added a comment. Please also mark resolved comments as done, otherwise reviewers can presume that some comments are unresolved and don't necessarily give another round of reviews. Comment at: clang/test/Driver/print-supported-extensions.c:6 +// RUN: %clang --target=ri