[PATCH] D146595: [clang] Add "debug_trampoline" attribute

2023-04-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D146595#4284340 , @dblaikie wrote: > In D146595#4284268 , @aaron.ballman > wrote: > >> In D146595#4284220 , @dblaikie >> wrote: >> >>>

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

2023-04-20 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D146595#4284268 , @aaron.ballman wrote: > In D146595#4284220 , @dblaikie > wrote: > >> In D146595#4281710 , @aprantl >> wrote: >> >>> Now i

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

2023-04-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D146595#4284220 , @dblaikie wrote: > In D146595#4281710 , @aprantl wrote: > >> Now if we are going to say this explicitly DWARF only feature, that could be >> an argument to stic

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

2023-04-20 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D146595#4281710 , @aprantl wrote: > In D146595#4278361 , @dblaikie > wrote: > >> In D146595#4235340 , @augusto2112 >> wrote: >> >>> In D1465

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

2023-04-19 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. In D146595#4278361 , @dblaikie wrote: > In D146595#4235340 , @augusto2112 > wrote: > >> In D146595#4235333 , @aprantl >> wrote: >> >>> I hope I'

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

2023-04-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D146595#4235340 , @augusto2112 wrote: > In D146595#4235333 , @aprantl wrote: > >> I hope I'm not kicking off a long bike-shedding thread, but I would propose >> to either call the at

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

2023-04-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. The Clang attribute bits generally LG, but I don't know enough on the debug info bits to say. In terms of behavior in PDB files, I'd still like for this attribute to be supported across all debug info formats. If we know this attribute is going to be ignored for a

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

2023-04-06 Thread Augusto Noronha via Phabricator via cfe-commits
augusto2112 updated this revision to Diff 511515. augusto2112 added a comment. Updated MetadataTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

2023-04-06 Thread Augusto Noronha via Phabricator via cfe-commits
augusto2112 added a comment. @aaron.ballman thanks all the code reviews. In D146595#4240608 , @aaron.ballman wrote: > Additionally, should you be allowed to write this on a lambda to skip over > the function call operator? (If so, you may need to move

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

2023-04-06 Thread Augusto Noronha via Phabricator via cfe-commits
augusto2112 updated this revision to Diff 511513. augusto2112 added a comment. Added release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/docs/ReleaseNotes.rst clang/include/clang