[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43575719d0c6: [Clang] Fix crash caused by line splicing in doc comment (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148029/new/ https://reviews.llvm.org/D148029 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes seem reasonable to me. Comment at: clang/include/clang/AST/RawCommentList.h:122 +StringRef Text = getRawText(SourceMgr); +if (Text.size() <

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin added inline comments. Comment at: clang/include/clang/AST/RawCommentList.h:122 +StringRef Text = getRawText(SourceMgr); +if (Text.size() < 6 || Text[0] != '/') + return false; aaron.ballman wrote: > Just to double-check, we don't have to wo

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/RawCommentList.h:122 +StringRef Text = getRawText(SourceMgr); +if (Text.size() < 6 || Text[0] != '/') + return false; Just to double-check, we don't have to worry about there be

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin added a comment. In D148029#4258800 , @shafik wrote: > Do we have a test that covers valid doxygen comments? I was looking and I > don't see an obvious one. AFAICT, some in `CommentTextTest.cpp` - not that many though. Comme

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

shafik added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2404 break; +case RawComment::RCK_Invalid: + // FIXME: are there other scenarios that could produce an invalid I don't get why we don't have to handle the other `RawComment` cases h

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

shafik added a comment. Do we have a test that covers valid doxygen comments? I was looking and I don't see an obvious one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148029/new/ https://reviews.llvm.org/D148029 ___

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin updated this revision to Diff 512505. cor3ntin added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148029/new/ https://reviews.llvm.org/D148029 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Raw

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because the comment parser does not support slices, we emit a warning for comments that do contain a splice within their d