[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG176889868024: [MemProf] Control availability of hot/cold operator new from LTO link (authored by tejohnson). Changed prior to commit:

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

snehasish accepted this revision. snehasish added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp:3163 + // TODO: If/when other types of memprof cloning are enabled beyond just for + //

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson updated this revision to Diff 518721. tejohnson added a comment. Address comment (add TODO about automatically detecting support) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149215/new/ https://reviews.llvm.org/D149215 Files:

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

pcc added a comment. In D149215#4303197 , @tejohnson wrote: > In D149215#4303149 , @pcc wrote: > >>> Adds an LTO option >> >> Usual question: does it need to be an option? Could the allocator expose a >> symbol

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson added a comment. In D149215#4303149 , @pcc wrote: >> Adds an LTO option > > Usual question: does it need to be an option? Could the allocator expose a > symbol such as `__malloc_hot_cold` that the linker could check for in the > symbol table?

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

pcc added a comment. > Adds an LTO option Usual question: does it need to be an option? Could the allocator expose a symbol such as `__malloc_hot_cold` that the linker could check for in the symbol table? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson updated this revision to Diff 517678. tejohnson added a comment. Expand command and patch description for mechanism used by distributed ThinLTO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149215/new/ https://reviews.llvm.org/D149215

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson updated this revision to Diff 517044. tejohnson added a comment. Remove extraneous call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149215/new/ https://reviews.llvm.org/D149215 Files:

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson updated this revision to Diff 517043. tejohnson added a comment. Rebase onto latest D149117 to remove extraneous test diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149215/new/

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson added a comment. This was refactored out of patch 3 (the applyImport stuff that I refactored into patch 4 in D149117 ). Previously I was controlling this behavior via the MemProfContextDisambiguation pass itself, but in refactoring I realized that it

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson created this revision. tejohnson added a reviewer: snehasish. Herald added subscribers: hoy, ormris, arphaman, steven_wu, hiraditya, inglorion. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: