This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG65dca4cbcbfc: [clang][Interp] Fix tests for ignored
expressions (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:593-594
+if (DiscardResult)
+ return true;
+
tbaeder wrote:
>
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:593-594
+if (DiscardResult)
+ return true;
+
aaron.ballman wrote:
> For my own understanding -- why do we not need to call `discard()` on the
> operand expression?
Is
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:593-594
+if (DiscardResult)
+ return true;
+
For my own understanding -- why do we not need to call `discard()` on the
operand expression?
tbaeder updated this revision to Diff 520352.
tbaeder added a comment.
@aaron.ballman This is where the sizeof/alignof tests were actually broken.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149965/new/
https://reviews.llvm.org/D149965
Files:
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We didn't call the function explicitly in a
