This revision was automatically updated to reflect the committed changes.
Closed by commit rGdaac014fec42: [clang-tidy] Check functions called from catch
blocks (authored by denizevrenci).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152330/new/
ht
denizevrenci updated this revision to Diff 530296.
denizevrenci added a comment.
Rebase on main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152330/new/
https://reviews.llvm.org/D152330
Files:
clang-tools-extra/clang-tidy/utils/ExceptionAnalyze
denizevrenci updated this revision to Diff 529140.
denizevrenci added a comment.
Sort tests out a bit more
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152330/new/
https://reviews.llvm.org/D152330
Files:
clang-tools-extra/clang-tidy/utils/Excep
denizevrenci updated this revision to Diff 529137.
denizevrenci added a comment.
Sort out tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152330/new/
https://reviews.llvm.org/D152330
Files:
clang-tools-extra/clang-tidy/utils/ExceptionAnalyze
denizevrenci updated this revision to Diff 529134.
denizevrenci added a comment.
Rebase on main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152330/new/
https://reviews.llvm.org/D152330
Files:
clang-tools-extra/clang-tidy/utils/ExceptionAnalyze
ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.
LGTM. And please wait for several days for other reviewers.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:132-136
if c
denizevrenci added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:132-136
if constexpr (ThrowInUnhandledException) {
throw 1;
+} else if constexpr (RethrowInUnhandledException) {
+ throw;
}
---
ChuanqiXu added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:132-136
if constexpr (ThrowInUnhandledException) {
throw 1;
+} else if constexpr (RethrowInUnhandledException) {
+ throw;
}
--
denizevrenci created this revision.
denizevrenci added reviewers: njames93, PiotrZSL, ChuanqiXu.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
denizevrenci requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe