[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

2023-06-11 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D152443#4412069 , @KitsuneAlex wrote: > This revision of the diff changes the names of the new style options to > **SpaceAfterOperatorOverload** and **SpaceAfterOperatorCall**, which > clarifies their scope a lot

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

2023-06-11 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex updated this revision to Diff 530303. KitsuneAlex marked 2 inline comments as done. KitsuneAlex removed reviewers: lattner, craig.topper, RKSimon, respindola, rymiel, owenpan. KitsuneAlex added a comment. Herald added reviewers: rymiel, owenpan. This revision of the diff changes the

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

2023-06-09 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex added a comment. In D152443#4408991 , @MyDeveloperDay wrote: > In D152443#4407438 , @KitsuneAlex > wrote: > >> I had some issues with Git there because i messed up a merge, so the diff >> was bad.

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

2023-06-09 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D152443#4407331 , @KitsuneAlex wrote: > Applied all suggested changes and added a suiting option for aformentioned > edge-case for call expressions. > Also added the missing release notes to the apropriate

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

2023-06-09 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D152443#4407438 , @KitsuneAlex wrote: > I had some issues with Git there because i messed up a merge, so the diff was > bad. Here's the proper diff. > NOTE: Clang-Format Team Automated Review Comment keep you

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

2023-06-09 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4709 + +**SpaceAfterOperatorKeyword** (``Boolean``) :versionbadge:`clang-format 17` :ref:`¶ ` + If ``true``, a space will be inserted after the 'operator' keyword. could

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

2023-06-08 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex updated this revision to Diff 529804. KitsuneAlex added a comment. Clean up the formatting with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/ https://reviews.llvm.org/D152443 Files:

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

2023-06-08 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex updated this revision to Diff 529799. KitsuneAlex added a comment. I had some issues with Git there because i messed up a merge, so the diff was bad. Here's the proper diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

2023-06-08 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex updated this revision to Diff 529798. KitsuneAlex added a comment. Some additional changes because i exceeded the maximum line width on multiple occasions. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review contains a change to