[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

2023-06-22 Thread Craig Topper via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4a93d80f425: [RISCV] Sort the extensions in SupportedExtensions and… (authored by craig.topper). Changed prior to commit: https://reviews.llvm.or

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

2023-06-22 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. OK, if this patch is going to verify the table is sorted then SupportedExtensions and SupportedExperimentalExtensions probably deserve a comment to explicitly note they must be kept in sort order. Otherwise, still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

2023-06-22 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 533678. craig.topper added a comment. Verify the table is sorted. This uses the same pattern we use to check sorted tables in other places like X86InstrFMA3Info.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

2023-06-22 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D153170#4441462 , @jrtc27 wrote: > Can we have an expensive check that the table is sorted? Yeah. I was going to do it when I made use of the sorted property, but it makes more sense to be in this patch. I'll probably do

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

2023-06-22 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. Can we have an expensive check that the table is sorted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153170/new/ https://reviews.llvm.org/D153170 ___ cfe-commits mailing list cf

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

2023-06-22 Thread Alex Bradbury via Phabricator via cfe-commits
asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153170/new/ https://reviews.llvm.org/D153170 ___ cfe-

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

2023-06-16 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: jrtc27, asb, kito-cheng, wangpc, reames. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,