This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rGaa964f157f9b: [HIP] Fix -mllvm option for device lld linker
(authored by yaxunl).
Herald added a project:
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:164
+StringRef ArgVal = Arg->getValue(1);
+if (ArgVal.startswith("-mllvm=")) {
+ ArgVal = ArgVal.substr(strlen("-mllvm="));
jhuber6 added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:164
+StringRef ArgVal = Arg->getValue(1);
+if (ArgVal.startswith("-mllvm=")) {
+ ArgVal = ArgVal.substr(strlen("-mllvm="));
arsenm wrote:
> StringRef Prefix("-mllvm=")
arsenm added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:164
+StringRef ArgVal = Arg->getValue(1);
+if (ArgVal.startswith("-mllvm=")) {
+ ArgVal = ArgVal.substr(strlen("-mllvm="));
StringRef Prefix("-mllvm=") and then use the
jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.
LG, thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154145/new/
https://reviews.llvm.org/D154145
___
cfe-commits mailing list
yaxunl created this revision.
yaxunl added reviewers: tra, jhuber6.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added a subscriber: MaskRay.
currently clang passes -mllvm options to the device lld linker plugin
when compiling HIP. This is against default clang
