This revision was automatically updated to reflect the committed changes.
Closed by commit rG2806cf4b5430: [clang-tidy] Fix width/precision argument
order in modernize-use-std-print (authored by mikecrowe, committed by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.h:73
+ // puts the width and preicision first.
+ std::vector> ArgRotates;
+
mikecrowe wrote:
> PiotrZSL wrote:
> > mikecrowe wrote:
> > > PiotrZSL wrote:
> > >
mikecrowe added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.h:73
+ // puts the width and preicision first.
+ std::vector> ArgRotates;
+
PiotrZSL wrote:
> mikecrowe wrote:
> > PiotrZSL wrote:
> > > NOTE: You can use std:
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.h:73
+ // puts the width and preicision first.
+ std::vector> ArgRotates;
+
mikecrowe wrote:
> PiotrZSL wrote:
> > NOTE: You can use std::pair here.
> True, but
mikecrowe updated this revision to Diff 536595.
mikecrowe added a comment.
Use emplace_back rather than push_back(make_tuple())
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154283/new/
https://reviews.llvm.org/D154283
Files:
clang-tools-extra/c
mikecrowe added a comment.
Thanks for the review.
Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:356-357
+ if (ArgCount)
+ArgRotates.push_back(
+std::make_tuple(FS.getArgIndex() + ArgsOffset, ArgCount));
+}
PiotrZSL wrote:
PiotrZSL added a comment.
Just few nits, from functionally point of view looks fine.
Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:356-357
+ if (ArgCount)
+ArgRotates.push_back(
+std::make_tuple(FS.getArgIndex() + ArgsOffset, ArgCount));
mikecrowe created this revision.
mikecrowe added a reviewer: PiotrZSL.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
mikecrowe requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscribe
