[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53b6a169e453: [SPIR-V] Add SPIR-V logical triple. (authored by Keenuts). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts added a comment. > Either I could push the patch for you (adding you as an author) or preferably > you could gain commit access yourself for this and future patches. Thanks, got commit access. Running tests again and merging this. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

mpaszkowski added a comment. In D155978#4639499 , @Keenuts wrote: > In D155978#4639094 , @mpaszkowski > wrote: > >> @Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I >> think that this

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts added a comment. In D155978#4639094 , @mpaszkowski wrote: > @Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I > think that this solution despite being a "hack" seems to be the most > straightforward. Eventual

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

mpaszkowski accepted this revision. mpaszkowski added a comment. This revision is now accepted and ready to land. @Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I think that this solution despite being a "hack" seems to be the most straightforward. Eventual differences

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts updated this revision to Diff 555745. Keenuts added a comment. Changed the pointer size to 32 bit to 64 bits. So far, I haven't see any codegen difference, as logical pointers do not have a fixed size (driver will set it). However, in case of a raw buffer load (Vulkan extension), with the

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts added inline comments. Comment at: llvm/unittests/TargetParser/TripleTest.cpp:1307 + EXPECT_TRUE(T.isSPIRV()); + T.setArch(Triple::spirv32); Keenuts wrote: > Anastasia wrote: > > pmatos wrote: > > > Keenuts wrote: > > > > pmatos wrote: > > > > > I am

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts added inline comments. Comment at: llvm/unittests/TargetParser/TripleTest.cpp:1307 + EXPECT_TRUE(T.isSPIRV()); + T.setArch(Triple::spirv32); Anastasia wrote: > pmatos wrote: > > Keenuts wrote: > > > pmatos wrote: > > > > I am not well-versed in SPIRV

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Anastasia added inline comments. Comment at: llvm/unittests/TargetParser/TripleTest.cpp:1307 + EXPECT_TRUE(T.isSPIRV()); + T.setArch(Triple::spirv32); pmatos wrote: > Keenuts wrote: > > pmatos wrote: > > > I am not well-versed in SPIRV for gfx but if we are

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts marked an inline comment as done. Keenuts added inline comments. Comment at: llvm/include/llvm/TargetParser/Triple.h:106 +wasm32, // WebAssembly with 32-bit pointers +wasm64, // WebAssembly with 64-bit pointers renderscript32, // 32-bit

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

pmatos added inline comments. Comment at: llvm/include/llvm/TargetParser/Triple.h:106 +wasm32, // WebAssembly with 32-bit pointers +wasm64, // WebAssembly with 64-bit pointers renderscript32, // 32-bit RenderScript Keenuts wrote: > pmatos

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts marked 4 inline comments as done. Keenuts added a comment. Thanks for the review  Reverted clang-format patch, and answered inline. Comment at: llvm/include/llvm/TargetParser/Triple.h:106 +wasm32, // WebAssembly with 32-bit pointers +wasm64, //

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts updated this revision to Diff 549288. Keenuts added a comment. Revert "clang-format" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155978/new/ https://reviews.llvm.org/D155978 Files: clang/lib/Basic/Targets.cpp

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

pmatos added subscribers: iliya-diyachkov, zuban32. pmatos added a comment. Thanks for the patch. Left a few comments. Others can take a better look, I am sure. Maybe @iliya-diyachkov or @zuban32 can take a look as well. Comment at: llvm/include/llvm/TargetParser/Triple.h:106