[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548589. victorkingi added a comment. split the patch into 2. This is the implementation patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/inclu

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi added a comment. In D156320#4559248 , @kiranchandramohan wrote: >> rpass flag now prints remarks when requested but does not display >> the passName used, i.e [-Rpass=inline] > > I think the location information is also not printed. Please ch

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548175. victorkingi added a comment. changed enum to enum class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td c

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548148. victorkingi added a comment. from CamelCase to camelCase variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Opt

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548142. victorkingi added a comment. fixing failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td clang/l

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi added a comment. In D156320#4560839 , @awarzynski wrote: > Hey @victorkingi , thank you for working on this :) > > There's quite a lot going on here and I am thinking that it might be good to > split this into a few patches? Also, please not

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 547817. victorkingi added a comment. code cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td clang/lib/Basic

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 547816. victorkingi added a comment. removed unnecessary code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td cla

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 547813. victorkingi added a comment. Herald added a subscriber: wangpc. added extraction of absolute file path in TextDiagnosticPrinter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://revi

[PATCH] D156320: [FLang] Add support for Rpass flag

awarzynski added a comment. Hey @victorkingi , thank you for working on this :) There's quite a lot going on here and I am thinking that it might be good to split this into a few patches? Also, please note that Flang's driver, unlike Clang, uses MLIR's coding style (use `camelCase` instead of `

[PATCH] D156320: [FLang] Add support for Rpass flag

tschuett added inline comments. Comment at: flang/include/flang/Frontend/CodeGenOptions.h:72 + enum RemarkKind { +RK_Missing,// Remark argument not present on the command line. enum class? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D156320: [FLang] Add support for Rpass flag

kiranchandramohan added a comment. > rpass flag now prints remarks when requested but does not display > the passName used, i.e [-Rpass=inline] I think the location information is also not printed. Please check the difference in implementation of the `TextDiagnosticPrinter::HandleDiagnostic` fu

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546831. victorkingi added a comment. removed unused header includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546826. victorkingi added a comment. added frontend forwarding test for Rpass flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/D

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546819. victorkingi added a comment. added test file optimization-remark.f90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/O

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546798. victorkingi added a comment. rpass flag now prints remarks when requested but does not display the passName used, i.e [-Rpass=inline] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https:

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added