This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3e014038b373: [analyzer] Improve underflow handling in
ArrayBoundV2 (authored by donat.nagy).
Changed prior to commit:
https://reviews.llvm.org/D1
donat.nagy added a comment.
Yup, there was a superfluous line break that was corrected by git clang-format;
thanks for bringing it to my attention. As this is a very trivial change, I'll
merge the fixed commit directly, without uploading it into Phabricator.
Comment at: clang
steakhal added a comment.
Hold on, make sure this is clang-format compliant before committing.
(Check buildkite)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157104/new/
https://reviews.llvm.org/D157104
___
steakhal accepted this revision.
steakhal added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157104/new/
https://reviews.llvm.org/D157104
___
cfe-commits mailing list
cfe-commits@list
donat.nagy added a comment.
A (somewhat delayed) ping to @steakhal because you asked me to tell you when I
have the results. (If you've already seen the table that I uploaded on Friday,
then you've nothing to do.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
donat.nagy added a comment.
The results on open-source projects are depressing, but acceptable. This
checker is looking for a serious defect, so it doesn't find any true positives
on stable versions of open-source projects; however it produces a steady
trickle of false positives because the Cla
donat.nagy marked 2 inline comments as done.
donat.nagy added a comment.
I didn't upload the test results yet because right now there is some
incompatibility between our local fork and the upstream. I hope that it'll be
fixed soon, but until then I can't use our automated tools to run the analys
donat.nagy updated this revision to Diff 549881.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157104/new/
https://reviews.llvm.org/D157104
Files:
clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp
clang/test/Analysis/out-of-bounds.c
In
steakhal accepted this revision.
steakhal added a comment.
Looks safe and good. I'm interested in the diff though.
Let me know once you have the results.
I wanna have a look before we land this.
Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:184
+// s
gamesh411 accepted this revision.
gamesh411 added a comment.
This revision is now accepted and ready to land.
Seems like a straightforward extension, LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157104/new/
https://reviews.llvm.org/D157104
donat.nagy added reviewers: dkrupp, steakhal, Szelethus, gamesh411.
donat.nagy added a comment.
I'll try to upload results on open source projects, probably on Tuesday (I'm on
vacation on Monday).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D15710
donat.nagy added a comment.
Note: this commit is split off from the larger commit
https://reviews.llvm.org/D150446, which combined this simple improvement with
other, more complex changes that had problematic side-effects.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
donat.nagy created this revision.
Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411,
dkrupp, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware,
xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
donat.nagy requested review of this revi
13 matches
Mail list logo
