bogner added inline comments.
Comment at: llvm/include/llvm/Option/OptParser.td:153
class Flags flags> { list Flags = flags; }
+class Vis vis> { list Vis = vis; }
class Group { OptionGroup Group = group; }
phosek wrote:
> Would it be possible to spell this out
phosek added inline comments.
Comment at: llvm/include/llvm/Option/OptParser.td:153
class Flags flags> { list Flags = flags; }
+class Vis vis> { list Vis = vis; }
class Group { OptionGroup Group = group; }
Would it be possible to spell this out in full, that is
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa16104e6da6f: [Option] Add "Visibility" field and
clone the OptTable APIs to use it (authored by bogner).
Repository:
rG LLVM Github Monorepo
CHA
beanz accepted this revision.
beanz added a comment.
LGTM. This is definitely an improvement over the awfulness we were doing.
Thanks @bogner!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157149/new/
https://reviews.llvm.org/D157149
bogner updated this revision to Diff 550055.
bogner edited the summary of this revision.
bogner added a comment.
Update comment wording to be less ambiguous about flags vs visibility
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157149/new/
https:/
MaskRay accepted this revision.
MaskRay added subscribers: python3kgae, beanz.
MaskRay added a comment.
This revision is now accepted and ready to land.
> ... but it really doesn't scale well, as can be seen by things like the
> somewhat recently introduced CLDXCOption.
FYI @beanz @python3kgae D
bogner updated this revision to Diff 549111.
bogner added a comment.
Resolve conflicts
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157149/new/
https://reviews.llvm.org/D157149
Files:
clang-tools-extra/clangd/CompileCommands.cpp
clang/lib/Fro
bogner updated this revision to Diff 548832.
bogner added a comment.
Rebase/resolve conflicts
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157149/new/
https://reviews.llvm.org/D157149
Files:
clang-tools-extra/clangd/CompileCommands.cpp
clang/
bogner created this revision.
bogner added a reviewer: MaskRay.
Herald added subscribers: pmatos, asb, ormris, kadircet, arphaman, steven_wu,
hiraditya, sbc100, mcrosier.
Herald added a reviewer: JDevlieghere.
Herald added a reviewer: alexander-shaposhnikov.
Herald added a reviewer: jhenderson.
He
