[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sdesmalen marked 4 inline comments as done. Closed by commit rG453c30e9e633: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions. (authored by

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang/lib/Sema/SemaChecking.cpp:6773 + bool CallerHasZAState = false; + if (auto *CallerFD = dyn_cast(CurContext))

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen updated this revision to Diff 548131. sdesmalen added a comment. Added test-cases for indirect calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157270/new/ https://reviews.llvm.org/D157270 Files:

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK rsandifo-arm wrote: > sdesmalen wrote: > > rsandifo-arm wrote: > > > sdesmalen wrote: > > > > rsandifo-arm

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

rsandifo-arm added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK sdesmalen wrote: > rsandifo-arm wrote: > > sdesmalen wrote: > > > rsandifo-arm wrote: > > > > Would be good

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK rsandifo-arm wrote: > sdesmalen wrote: > > rsandifo-arm wrote: > > > Would be good to have some tests for

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen updated this revision to Diff 547936. sdesmalen marked an inline comment as done. sdesmalen added a comment. - Replaced `|=` into normal assignment `=` - Added test for global initializer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

rsandifo-arm added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK sdesmalen wrote: > rsandifo-arm wrote: > > Would be good to have some tests for indirect function calls too

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK rsandifo-arm wrote: > Would be good to have some tests for indirect function calls too (via > function

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

rsandifo-arm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6737 +else if (const auto *FPT = CallerFD->getType()->getAs()) + CallerHasZAState |= FPT->getExtProtoInfo().AArch64SMEAttributes & +

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen created this revision. sdesmalen added reviewers: rsandifo-arm, aaron.ballman. Herald added a subscriber: kristof.beyls. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The caller is