[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf263f45ba649: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions`… (authored by fwolff). Repository: rG LLVM Github

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff marked an inline comment as done. fwolff added a comment. Thanks for reviewing this @PiotrZSL! In D157428#4570497 , @PiotrZSL wrote: > What about switchStmt ? The `AllowIntegerConditions` and `AllowPointerConditions` options only apply to `int

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff updated this revision to Diff 548342. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428 Files: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- Improved :doc:`readability-implicit-bool-conversion + ` check to take do-while loops into + account for the ``AllowIntegerConditions`` and ``AllowPointerConditions`` + options.

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff updated this revision to Diff 548334. fwolff added a comment. Mention this change in the release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428 Files:

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

PiotrZSL added a comment. Missing release notes, except that looks fine. What about switchStmt ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428 ___

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff created this revision. fwolff added reviewers: PiotrZSL, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. fwolff requested review of this revision. Herald added a