[PATCH] D16171: Warning on redeclaring with a conflicting asm label

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D16171#540261, @phabricss wrote: > ../include/sys/stat.h:16:15: error: cannot apply asm label to function > after its first use > hidden_proto

[PATCH] D16171: Warning on redeclaring with a conflicting asm label

rsmith added a comment. Er, please ignore the inline review comments; those predated the realisation that this doesn't actually fix the glibc build problem. https://reviews.llvm.org/D16171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16171: Warning on redeclaring with a conflicting asm label

xiangzhai added a comment. LLVMBUG-31017 https://llvm.org/bugs/show_bug.cgi?id=31017#c4 In https://reviews.llvm.org/D16171#540261, @phabricss wrote: > On 09/12/2016 01:26 PM, Nick Lewycky wrote: > > > Firstly, I thought glibc had applied a patch to fix this bug? As in, the > > error is correct

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

Sorry, I was distracted by other issues after I uploaded the patch. I will take another look of the implementation. Thanks, Weiming On 9/12/2016 1:31 PM, Sam Shepperd wrote: phabricss added a comment. On 09/12/2016 01:26 PM, Nick Lewycky wrote: Firstly, I thought glibc had applied a

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

phabricss added a comment. On 09/12/2016 01:26 PM, Nick Lewycky wrote: > Firstly, I thought glibc had applied a patch to fix this bug? As in, the > error is correct and glibc fixed their bug? I can confirm that the bug still exists in glibc 2.24 and HEAD from glibc git. Also it appears that

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

On 11 September 2016 at 21:14, Sam Shepperd via cfe-commits < cfe-commits@lists.llvm.org> wrote: > phabricss added a subscriber: phabricss. > phabricss added a comment. > > It is still impossible to compile glibc with clang due to this bug. Could > this patch be reviewed please. > Firstly, I

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

phabricss added a subscriber: phabricss. phabricss added a comment. It is still impossible to compile glibc with clang due to this bug. Could this patch be reviewed please. https://reviews.llvm.org/D16171 ___ cfe-commits mailing list

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

Weiming Zhao wrote: weimingz created this revision. weimingz added a reviewer: nicholas. weimingz added a subscriber: cfe-commits. r255371 errors on redeclaring with a conflicting asm label. This patch changes errors to warnings to prevent breaking existing codes. Can you include a testcase

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

nicholas added a subscriber: nicholas. nicholas added a comment. Weiming Zhao wrote: > weimingz created this revision. > weimingz added a reviewer: nicholas. > weimingz added a subscriber: cfe-commits. > > r255371 errors on redeclaring with a conflicting asm label. > This patch changes

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

On Thu, Jan 14, 2016 at 02:05:21AM +, Weiming Zhao via cfe-commits wrote: > r255371 errors on redeclaring with a conflicting asm label. > This patch changes errors to warnings to prevent breaking existing codes. I'm not sure I agree with this. We have triggered this in NetBSD in two different

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

On 14 January 2016 at 10:38, Weiming Zhao via cfe-commits < cfe-commits@lists.llvm.org> wrote: > weimingz added a comment. > > Hi Nick, > > Below is a reduced code: > t.c: > > static long double acoshl (long double __x) __asm__ ("" "acosh") ; // > this is from

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

weimingz updated this revision to Diff 44931. weimingz added a comment. if the new decl is not used, we can just give warnings http://reviews.llvm.org/D16171 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/Sema/asm-label.c Index: test/Sema/asm-label.c

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

I agree what you said about different code generated with clang and GCC generates. In this case, we should throw an error (err_late_asm_label). But in this example, there is no use of the function. They are just redundant declarations and there is no actual code generated. So I suggest we just

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

On 14 January 2016 at 15:05, Zhao, Weiming wrote: > I agree what you said about different code generated with clang and GCC > generates. In this case, we should throw an error (err_late_asm_label). > > But in this example, there is no use of the function. They are just >

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

On Thu, Jan 14, 2016 at 03:05:26PM -0800, Zhao, Weiming via cfe-commits wrote: > I agree what you said about different code generated with clang and GCC > generates. In this case, we should throw an error (err_late_asm_label). > > But in this example, there is no use of the function. They are

[PATCH] D16171: Warning on redeclaring with a conflicting asm label

weimingz created this revision. weimingz added a reviewer: nicholas. weimingz added a subscriber: cfe-commits. r255371 errors on redeclaring with a conflicting asm label. This patch changes errors to warnings to prevent breaking existing codes. http://reviews.llvm.org/D16171 Files: