This revision was automatically updated to reflect the committed changes.
Closed by commit rL260697: [CUDA] Tweak attribute-based overload resolution to
match nvcc behavior. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D16870?vs=47753=47819#toc
Repository:
rL LLVM
jingyue added a comment.
I'll defer to Justin's approval.
http://reviews.llvm.org/D16870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
Mostly comments on comments.
Comment at: lib/Sema/SemaCUDA.cpp:71
@@ -70,3 +70,3 @@
// H - handled in (x)
-// Preferences: b-best, f-fallback, l-last resort, n-never.
+// Preferences: +:native, *:host-device, o:same side, .:wrong side, -:never.
//
tra requested a review of this revision.
tra added a comment.
This revision is now accepted and ready to land.
@jingyue, @jlebar: can you take a look at the updated version?
http://reviews.llvm.org/D16870
___
cfe-commits mailing list
tra updated the summary for this revision.
tra updated this revision to Diff 47335.
tra marked 3 inline comments as done.
tra added a comment.
Updated the way WrongSide functions are removed from consideration during
overload resolution.
Previous version could provide inconsistent results
jingyue added inline comments.
Comment at: test/SemaCUDA/function-overload.cu:138
@@ -149,3 +137,3 @@
fp_t cdhp = cdh;
- gp_t gp = g; // expected-error {{reference to __global__ function 'g' in
__global__ function}}
- // expected-note@67 {{'g' declared here}}
+
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Looks sane to me. Just some suggestions on the comments.
Comment at: lib/Sema/SemaCUDA.cpp:71
@@ -70,3 +70,3 @@
// H - handled in (x)
-// Preferences: b-best, f-fallback,
tra marked an inline comment as done.
Comment at: lib/Sema/SemaCUDA.cpp:132-141
@@ -131,12 +131,12 @@
// (d) HostDevice behavior depends on compilation mode.
if (CallerTarget == CFT_HostDevice) {
// Calling a function that matches compilation mode is OK.
//
tra updated this revision to Diff 46927.
tra marked an inline comment as done.
tra added a comment.
Addressed Jingyue's comments.
Fixed function-overload.cu tests to reflect stricter call target checks.
http://reviews.llvm.org/D16870
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
tra created this revision.
tra added reviewers: jlebar, jingyue, jpienaar, eliben.
tra added a subscriber: cfe-commits.
This is an artefact of split-mode CUDA compilation that we need to
mimic. HD functions are sometimes allowed to call H or D functions. Due
to split compilation mode device-side
jingyue added inline comments.
Comment at: include/clang/Sema/Sema.h:8801
@@ -8798,3 +8800,3 @@
// LangOpts.CUDADisableTargetCallChecks is true.
-CFP_Fallback, // Low priority caller/callee combination
-CFP_Best, // Preferred caller/callee
tra added a comment.
When overload set contains h and HD functions that are otherwise equal for
overload resolution, you want to be able to tell which one is better.
http://reviews.llvm.org/D16870
___
cfe-commits mailing list
12 matches
Mail list logo
