Re: [PATCH] D16962: clang-tidy: avoid std::bind

This revision was automatically updated to reflect the committed changes. Closed by commit rL269341: [clang-tidy] Adds modernize-avoid-bind check (authored by jbcoe). Changed prior to commit: http://reviews.llvm.org/D16962?vs=57067=57095#toc Repository: rL LLVM

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe updated this revision to Diff 57067. jbcoe added a comment. update diff to allow arc to apply patch. http://reviews.llvm.org/D16962 Files: clang-tidy/modernize/AvoidBindCheck.cpp clang-tidy/modernize/AvoidBindCheck.h clang-tidy/modernize/CMakeLists.txt

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe added a comment. I can submit the patch myself, thanks. Thanks again for taking the time to give such a thorough review. http://reviews.llvm.org/D16962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16962: clang-tidy: avoid std::bind

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you! Do you need someone to submit the patch for you? Comment at: clang-tidy/modernize/AvoidBindCheck.cpp:28 @@ +27,3 @@ + BindArgumentKind Kind =

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe updated this revision to Diff 57022. jbcoe marked 6 inline comments as done. jbcoe added a comment. Apply fixes from review. http://reviews.llvm.org/D16962 Files: clang-tidy/modernize/AvoidBindCheck.cpp clang-tidy/modernize/AvoidBindCheck.h clang-tidy/modernize/CMakeLists.txt

Re: [PATCH] D16962: clang-tidy: avoid std::bind

Modernize it is then. The check currently only catches std::bind but further work can address that. Jon > On 4 May 2016, at 22:40, Arthur O'Dwyer wrote: > >> On Wed, May 4, 2016 at 1:43 PM, Aaron Ballman via cfe-commits >> wrote: >>

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe removed a reviewer: djasper. jbcoe updated this revision to Diff 56273. jbcoe added a comment. Move to modernize. Rename to `avoid-bind` as a later patch will add support for `boost::bind`, `std::bind1st` etc. http://reviews.llvm.org/D16962 Files:

Re: [PATCH] D16962: clang-tidy: avoid std::bind

On Wed, May 4, 2016 at 1:43 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > jbcoe wrote: > > aaron.ballman wrote: > > > I believe we use "modernize" to really mean "migrate from the old way > to the new way", which this definitely fits into since I think the point to >

Re: [PATCH] D16962: clang-tidy: avoid std::bind

aaron.ballman added inline comments. Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17 @@ -15,2 +16,2 @@ #include "ContainerSizeEmptyCheck.h" #include "DeletedDefaultCheck.h" jbcoe wrote: > aaron.ballman wrote: > > I believe we use "modernize" to

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe added inline comments. Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17 @@ -15,2 +16,2 @@ #include "ContainerSizeEmptyCheck.h" #include "DeletedDefaultCheck.h" aaron.ballman wrote: > I believe we use "modernize" to really mean "migrate from

Re: [PATCH] D16962: clang-tidy: avoid std::bind

aaron.ballman added inline comments. Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17 @@ -15,2 +16,2 @@ #include "ContainerSizeEmptyCheck.h" #include "DeletedDefaultCheck.h" I believe we use "modernize" to really mean "migrate from the old way to

Re: [PATCH] D16962: clang-tidy: avoid std::bind

alexfh added a comment. Please regenerate the patch with the full context (see http://llvm.org/docs/Phabricator.html). Comment at: clang-tidy/readability/AvoidStdBindCheck.cpp:77 @@ +76,3 @@ + for (size_t I = 1; I <= PlaceholderCount; ++I) { +Stream << Delimiter << "auto

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe updated this revision to Diff 55970. jbcoe marked 16 inline comments as done. jbcoe added a comment. Minor fixes from review. http://reviews.llvm.org/D16962 Files: clang-tidy/readability/AvoidStdBindCheck.cpp clang-tidy/readability/AvoidStdBindCheck.h

Re: [PATCH] D16962: clang-tidy: avoid std::bind

aaron.ballman added inline comments. Comment at: clang-tidy/readability/AvoidStdBindCheck.cpp:116 @@ +115,3 @@ + Finder->addMatcher( + callExpr(callee(namedDecl(isStdBind())), + hasArgument(0, declRefExpr(to(functionDecl().bind("f") alexfh

Re: [PATCH] D16962: clang-tidy: avoid std::bind

alexfh added inline comments. Comment at: clang-tidy/readability/AvoidStdBindCheck.cpp:46 @@ +45,3 @@ +BindArgument B; +if (const auto * M = dyn_cast(E)) { + const auto * TE = M->GetTemporaryExpr(); In LLVM style this should be `const auto *M`.

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe added inline comments. Comment at: clang-tidy/readability/AvoidStdBindCheck.cpp:42 @@ +41,3 @@ + + for (size_t I = 1, ArgCount = C->getNumArgs(); I < ArgCount; ++I) { +const Expr *E = C->getArg(I); alexfh wrote: > Please use a range-based for loop over

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe updated this revision to Diff 50623. jbcoe marked 15 inline comments as done. jbcoe added a comment. Apply requested fixes from review. Thanks for taking time to review this, the patch is much improved for the attention. http://reviews.llvm.org/D16962 Files:

Re: [PATCH] D16962: clang-tidy: avoid std::bind

alexfh added inline comments. Comment at: clang-tidy/readability/AvoidStdBindCheck.cpp:37 @@ +36,3 @@ + +std::vector +buildBindArguments(const MatchFinder::MatchResult , const CallExpr *C) { `SmallVector<>` would be better here, since the number of arguments is

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe planned changes to this revision. jbcoe added a comment. Placeholder handling needs correcting. Repository: rL LLVM http://reviews.llvm.org/D16962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 47247. jbcoe added a comment. Require C++14 for improved fixits. Do not attempt to generate fixits for more complicated uses of bind. http://reviews.llvm.org/D16962 Files:

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe updated this revision to Diff 47259. jbcoe added a comment. Moved check to readability module. Aside: would it be worthwhile creating a python script to move checks from one module to another? http://reviews.llvm.org/D16962 Files: clang-tidy/readability/AvoidStdBindCheck.cpp

Re: [PATCH] D16962: clang-tidy: avoid std::bind

alexfh added a comment. In http://reviews.llvm.org/D16962#346822, @jbcoe wrote: > Moved check to readability module. > > Aside: would it be worthwhile creating a python script to move checks from > one module to another? It's reasonable to teach the `rename_check.py` script move across

[PATCH] D16962: clang-tidy: avoid std::bind

jbcoe created this revision. jbcoe added reviewers: aaron.ballman, alexfh, djasper. jbcoe added a subscriber: cfe-commits. jbcoe set the repository for this revision to rL LLVM. Replace std::bind with a lambda. Not yet working for member functions. Repository: rL LLVM