rjmccall added a comment.
Sure thing, r304951.
https://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Since I don't have commit access, could you commit this for me?
thanks...
don
https://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
hintonda added a comment.
Great, thanks John.
Yes, that's correct -- I do not have commit access.
https://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, looks great. Do you still not have commit access?
https://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llv
hintonda updated this revision to Diff 101503.
hintonda added a comment.
- Addressed comments.
https://reviews.llvm.org/D17215
Files:
lib/Sema/SemaTemplate.cpp
test/CXX/temp/temp.decls/temp.mem/p5.cpp
Index: test/CXX/temp/temp.decls/temp.mem/p5.cpp
rjmccall added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:8985
+// FIXME: Would this be considered an almost match as well?
+continue;
}
These continues that you're adding are already at the end of the loop body, so
this code
hintonda updated this revision to Diff 101482.
hintonda added a comment.
Fixes PR14211.
Since getMostSpecialized only handles FunctionTemplateDecl matches,
keep track of non-FunctionTemplateDecl matches and only call
getMostSpecialized if no non-FunctionTemplateDecl matches are found.
Added test
hintonda added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7848
@@ -7842,2 +7847,3 @@
+ }
}
}
Got it...
http://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lis
hintonda updated this revision to Diff 48031.
hintonda added a comment.
- Added assert and additional test
http://reviews.llvm.org/D17215
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr14211-crash-on-invalid.cpp
Index: test/SemaCXX/pr14211-crash-on-invalid.cpp
rjmccall added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7845
@@ -7842,1 +7844,3 @@
+ } else
+NonTemplateMatch = Method;
}
hintonda wrote:
> rjmccall wrote:
> > Could you add an assertion here that NonTemplateMatch is sti
hintonda added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7845
@@ -7842,1 +7844,3 @@
+ } else
+NonTemplateMatch = Method;
}
rjmccall wrote:
> Could you add an assertion here that NonTemplateMatch is still null? That
> sh
rjmccall added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7845
@@ -7842,1 +7844,3 @@
+ } else
+NonTemplateMatch = Method;
}
Could you add an assertion here that NonTemplateMatch is still null? That
should definitely neve
hintonda added a comment.
Btw, I don't have commit access, so if accepted, could you please commit for me.
http://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
hintonda updated this revision to Diff 47999.
hintonda added a comment.
- Renamed variables to make code self-documenting
http://reviews.llvm.org/D17215
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr14211-crash-on-invalid.cpp
Index: test/SemaCXX/pr14211-crash-on-invalid.cpp
=
rjmccall added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7829
@@ -7828,2 +7828,3 @@
UnresolvedSet<8> Matches;
+ FunctionDecl *Specialization = nullptr;
TemplateSpecCandidateSet FailedCandidates(D.getIdentifierLoc());
Please name this variable N
15 matches
Mail list logo
