[PATCH] D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

2016-03-19 Thread Mike Spertus via cfe-commits
mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner. mspertus added a subscriber: cfe-commits. This change shows members of `DeclContext` objects in the Visual Studio debugger. It will also cast a `TagType` like a class or a struct to a `DeclContext`, so its methods

Re: [PATCH] D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

2016-03-18 Thread Mike Spertus via cfe-commits
mspertus closed this revision. mspertus added a comment. Thanks, Aaron. Committed as revision 263794 http://reviews.llvm.org/D18261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

2016-03-19 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang.natvis:77 @@ +76,3 @@ + + + mspertus wrote: > aaron.ballman wrote: > > The only hard-wiring I see uses 3 bits, so

Re: [PATCH] D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

2016-03-19 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Mostly LGTM with one question about a comment. Comment at: clang.natvis:77 @@ +76,3 @@ + + + The only hard-wiring I see uses 3 bits, so is this comment still accurate? http://reviews.llvm.org/D18261 _

Re: [PATCH] D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

2016-03-20 Thread Mike Spertus via cfe-commits
mspertus added a comment. I think the code is correct as written, see response in comment Comment at: clang.natvis:77 @@ +76,3 @@ + + + aaron.ballman wrote: > The only hard-wiring I see uses 3 bits, so is this comment still accurate? I think the code is co