This revision was automatically updated to reflect the committed changes.
pcc marked an inline comment as done.
Closed by commit rL289584: CodeGen: New vtable group representation: struct of
vtable arrays. (authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D22296?vs=81264&id=8
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D22296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
pcc marked 3 inline comments as done.
pcc added inline comments.
Comment at: clang/include/clang/AST/VTableBuilder.h:255
+operator ArrayRef() const { return {data(), size()}; };
+ };
+
rjmccall wrote:
> Maybe this ought to be in LLVM as OwnedArrayRef? And t
pcc updated this revision to Diff 81264.
pcc added a comment.
- Address review comments
https://reviews.llvm.org/D22296
Files:
clang/include/clang/AST/VTableBuilder.h
clang/include/clang/Basic/LLVM.h
clang/lib/AST/VTableBuilder.cpp
clang/lib/CodeGen/CGCXX.cpp
clang/lib/CodeGen/CGVTT.c
rjmccall added a comment.
A couple minor suggestions, then LGTM.
Comment at: clang/include/clang/AST/VTableBuilder.h:255
+operator ArrayRef() const { return {data(), size()}; };
+ };
+
Maybe this ought to be in LLVM as OwnedArrayRef? And the more minimal
pcc updated this revision to Diff 80844.
pcc marked 6 inline comments as done.
pcc added a comment.
- Address review comments
https://reviews.llvm.org/D22296
Files:
clang/include/clang/AST/VTableBuilder.h
clang/lib/AST/VTableBuilder.cpp
clang/lib/CodeGen/CGCXX.cpp
clang/lib/CodeGen/CGVT
pcc added inline comments.
Comment at: clang/include/clang/AST/VTableBuilder.h:225
private:
+ std::vector VTableIndices;
+
rjmccall wrote:
> Does this actually grow, or should you use a representation more like
> VTableComponents? Or something custom that exp
rjmccall added a comment.
This seems reasonable to me. Just a few representational / API requests.
Comment at: clang/include/clang/AST/VTableBuilder.h:222
+ typedef llvm::DenseMap>
+ AddressPointsMapTy;
Please use a struct instead of std::pair.
=
pcc added a reviewer: rjmccall.
pcc added a comment.
John, may I ask you to take a look?
https://reviews.llvm.org/D22296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc updated this revision to Diff 80709.
pcc added a comment.
Refresh
https://reviews.llvm.org/D22296
Files:
clang/include/clang/AST/VTableBuilder.h
clang/lib/AST/VTableBuilder.cpp
clang/lib/CodeGen/CGCXX.cpp
clang/lib/CodeGen/CGVTT.cpp
clang/lib/CodeGen/CGVTables.cpp
clang/lib/Code
pcc added a comment.
Ping
https://reviews.llvm.org/D22296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc updated this revision to Diff 75493.
pcc added a comment.
Refresh
https://reviews.llvm.org/D22296
Files:
clang/include/clang/AST/VTableBuilder.h
clang/lib/AST/VTableBuilder.cpp
clang/lib/CodeGen/CGCXX.cpp
clang/lib/CodeGen/CGVTT.cpp
clang/lib/CodeGen/CGVTables.cpp
clang/lib/Code
pcc added a comment.
This should now be ready for review and unblocked by other changes (I split out
the inrange annotation to https://reviews.llvm.org/D24431).
https://reviews.llvm.org/D22296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
13 matches
Mail list logo
