Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

2016-09-12 Thread Martin Böhme via cfe-commits
This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rL281200: [CFG] Add iterator_ranges to CFG and CFGBlock. (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D23842?vs=69129&id=70981#toc Re

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

2016-09-06 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: include/clang/Analysis/CFG.h:526 @@ -524,1 +525,3 @@ typedef AdjacentBlocks::const_reverse_iterator const_pred_reverse_iterator; + typedef llvm::iterator_range pred_range; + typedef llvm::iterator_range

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

2016-08-25 Thread Martin Böhme via cfe-commits
mboehme marked an inline comment as done. Comment at: include/clang/Analysis/CFG.h:526 @@ -524,1 +525,3 @@ typedef AdjacentBlocks::const_reverse_iterator const_pred_reverse_iterator; + typedef llvm::iterator_range pred_range; + typedef llvm::iterator_ran

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

2016-08-24 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Actually, there's just one comment. Otherwise it's looking good. https://reviews.llvm.org/D23842 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

2016-08-24 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/Analysis/CFG.h:526 @@ -524,1 +525,3 @@ typedef AdjacentBlocks::const_reverse_iterator const_pred_reverse_iterator; + typedef llvm::iterator_range

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

2016-08-24 Thread Martin Böhme via cfe-commits
mboehme updated this revision to Diff 69129. mboehme added a comment. Re-add inadvertently deleted blank line https://reviews.llvm.org/D23842 Files: include/clang/Analysis/CFG.h Index: include/clang/Analysis/CFG.h === --- includ

[PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

2016-08-24 Thread Martin Böhme via cfe-commits
mboehme created this revision. mboehme added a reviewer: alexfh. mboehme added a subscriber: cfe-commits. (Needed for D23353.) https://reviews.llvm.org/D23842 Files: include/clang/Analysis/CFG.h Index: include/clang/Analysis/CFG.h ==