Re: [PATCH] D25040: [Coverage] Do not emit coverage mappings for functions marked 'unused'

2016-09-28 Thread Vedant Kumar via cfe-commits
vsk added a comment. In https://reviews.llvm.org/D25040#556209, @arphaman wrote: > In https://reviews.llvm.org/D25040#556165, @vsk wrote: > > > In https://reviews.llvm.org/D25040#556109, @arphaman wrote: > > > > > Thanks for working on this, I have a couple of comments/questions: > > > > > > - Th

Re: [PATCH] D25040: [Coverage] Do not emit coverage mappings for functions marked 'unused'

2016-09-28 Thread Alex Lorenz via cfe-commits
arphaman added a comment. In https://reviews.llvm.org/D25040#556165, @vsk wrote: > In https://reviews.llvm.org/D25040#556109, @arphaman wrote: > > > Thanks for working on this, I have a couple of comments/questions: > > > > - The current logic doesn't work correctly for a test case that's shown

Re: [PATCH] D25040: [Coverage] Do not emit coverage mappings for functions marked 'unused'

2016-09-28 Thread Vedant Kumar via cfe-commits
vsk added a comment. In https://reviews.llvm.org/D25040#556109, @arphaman wrote: > Thanks for working on this, I have a couple of comments/questions: > > - The current logic doesn't work correctly for a test case that's shown below: > > ``` class C2 { void __attribute__((unused)) m4() { } void

Re: [PATCH] D25040: [Coverage] Do not emit coverage mappings for functions marked 'unused'

2016-09-28 Thread Alex Lorenz via cfe-commits
arphaman added a comment. Thanks for working on this, I have a couple of comments/questions: - The current logic doesn't work correctly for a test case that's shown below: class C2 { void __attribute__((unused)) m4() { } void __attribute__((unused)) m5(); }; The method 'm4' actually

[PATCH] D25040: [Coverage] Do not emit coverage mappings for functions marked 'unused'

2016-09-28 Thread Vedant Kumar via cfe-commits
vsk created this revision. vsk added a reviewer: arphaman. vsk added a subscriber: cfe-commits. This lets us suppress coverage reporting for ~30 functions across llvm and clang. I passed the test case through llvm-cov and verified that 'unused' functions are skipped, e.g: ``` 3| |voi