mgorny abandoned this revision.
mgorny added a comment.
https://reviews.llvm.org/D31864 covered all that was needed for Gentoo, and I
lack the knowledge to push the full split properly forward.
https://reviews.llvm.org/D25157
___
cfe-commits
mgorny added inline comments.
Comment at: cmake/config-ix.cmake:438-441
if (SANITIZER_COMMON_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND
+(COMPILER_RT_BUILD_SANITIZERS OR COMPILER_RT_BUILD_XRAY) AND
(OS_NAME MATCHES "Android|Darwin|Linux|FreeBSD" OR
(OS_NAME
compnerd added inline comments.
Comment at: cmake/config-ix.cmake:438-441
if (SANITIZER_COMMON_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND
+(COMPILER_RT_BUILD_SANITIZERS OR COMPILER_RT_BUILD_XRAY) AND
(OS_NAME MATCHES "Android|Darwin|Linux|FreeBSD" OR
(OS_NAME
weimingz added a comment.
Looks good to me but I'm not very familiar with the build of sanitizer and xray.
https://reviews.llvm.org/D25157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny updated this revision to Diff 93347.
mgorny added a comment.
Needed to rebase again.
https://reviews.llvm.org/D25157
Files:
cmake/config-ix.cmake
include/CMakeLists.txt
lib/CMakeLists.txt
test/sanitizer_common/CMakeLists.txt
Index: test/sanitizer_common/CMakeLists.txt
mgorny added inline comments.
Comment at: test/sanitizer_common/CMakeLists.txt:7
set(SUPPORTED_TOOLS)
-if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID)
+if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID AND
+ COMPILER_RT_HAS_ASAN)
jroelofs added inline comments.
Comment at: test/sanitizer_common/CMakeLists.txt:7
set(SUPPORTED_TOOLS)
-if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID)
+if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID AND
+ COMPILER_RT_HAS_ASAN)
mgorny updated this revision to Diff 93296.
mgorny added a comment.
Rebased. Ping. Now that we have lit tests for builtins, it would be really
useful for us to be able to build them without having to enable sanitizers.
https://reviews.llvm.org/D25157
Files:
cmake/config-ix.cmake
mgorny retitled this revision from "[compiler-rt] [cmake] Respect
COMPILER_RT_BUILD_* consistently for libs & tests" to "[compiler-rt] [cmake]
Respect COMPILER_RT_BUILD_* for libs, headers and tests".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 73198.
