rsmith added a comment.
In https://reviews.llvm.org/D25311#576382, @bkramer wrote:
> I think clang already depends on libclangRewrite. libclangToolingCore is
> tiny, it's basically just the Replacement class and a couple of utilities.
> While it would be possible to hoist just the include handl
bkramer added a comment.
In https://reviews.llvm.org/D25311#574806, @bruno wrote:
> I don't know the history behind the desired dependencies, I'll let others
> comment whether this is OK, but my guess it that it depends on the tradeoff,
> it's hard to justify 3 new deps for a change that is sup
sammccall added a comment.
> I don't know the history behind the desired dependencies, I'll let others
> comment whether this is OK, but my guess it that it depends on the tradeoff,
> it's hard to justify 3 new deps for a change that is supposed to be simple.
> How hard is to implement this wit
bruno added a comment.
Thanks for looking into this. It's a nice FixIt to have.
I don't see any dep cycle; clangFormat depends on clangToolingCore, which also
depends clangRewrite, which means there are going to be 3 new dependencies for
libSema in the end: clangToolingCore, clangRewrite and cl
sammccall added a comment.
Ping - let me know if there's a more appropriate reviewer!
https://reviews.llvm.org/D25311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a reviewer: rsmith.
sammccall added a comment.
(First patch, so please spell out mistakes!)
I think the big question is whether it's okay to depend on Format.
https://reviews.llvm.org/D25311
___
cfe-commits mailing list
cfe-commits@
sammccall created this revision.
sammccall added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
The line is inserted using clang-format's logic with LLVM style.
Users must run clang-format afterwards if they want some other style.
Alternatives:
respect .clang-format: this
