mgorny created this revision.
mgorny added reviewers: ddunbar, beanz.
mgorny added a subscriber: cfe-commits.
Add the build llvm_shlib_dir into LD_LIBRARY_PATH before the directory
specified as llvm_libs_dir, in order to fix stand-alone builds
attempting to use installed clang libraries.
In case
mgorny added a comment.
Ping.
https://reviews.llvm.org/D26115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz added inline comments.
Comment at: test/lit.cfg:109
+if not llvm_shlib_dir:
+lit_config.fatal('No LLVM shlib dir set!')
llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)
Should this really be fatal? It seems to me in many cases you mig
mgorny added inline comments.
Comment at: test/lit.cfg:109
+if not llvm_shlib_dir:
+lit_config.fatal('No LLVM shlib dir set!')
llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)
beanz wrote:
> Should this really be fatal? It seems to me in ma
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/lit.cfg:109
+if not llvm_shlib_dir:
+lit_config.fatal('No LLVM shlib dir set!')
llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286952: [test] Correctly include build llvm_shlib_dir in
stand-alone builds (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D26115?vs=76296&id=77982#toc
Repository:
rL LLVM
h