joey closed this revision.
joey added a comment.
Committed in r288332. Thanks Yaron!
Repository:
rL LLVM
https://reviews.llvm.org/D27049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
yaron.keren accepted this revision.
yaron.keren added a comment.
This revision is now accepted and ready to land.
LGTM after fixing the inline comment
Comment at: lib/Serialization/ASTReader.cpp:5804
QualType ElementType = readType(*Loc.F, Record, Idx);
-return Context
joey updated this revision to Diff 79399.
joey added a comment.
Pipe types cannot be merged by ASTContext::mergeTypes.
Repository:
rL LLVM
https://reviews.llvm.org/D27049
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
include/clang/Serialization/ASTBitCodes.h
lib/AST/
yaron.keren added inline comments.
Comment at: lib/AST/ASTContext.cpp:8258
return RHS;
-return isa(LHS) ? getReadPipeType(ResultType)
- : getWritePipeType(ResultType);
+const PipeType *PT = LHS->getAs();
+return PT->isReadOnly()
joey created this revision.
joey added reviewers: yaron.keren, bader.
joey added a subscriber: cfe-commits.
joey set the repository for this revision to rL LLVM.
Herald added a subscriber: yaxunl.
This patch to keep the pipe access qualifier inside PipeType itself looks
cleaner overall than my pr
