Zeson abandoned this revision.
Zeson added a comment.
I think this revision is out-of-date. I'd like to abandon it.
https://reviews.llvm.org/D27251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nemanjai added a comment.
@Zeson are you working on an update to this or is this to be abandoned?
https://reviews.llvm.org/D27251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbarton added a comment.
Sorry, I don't have time to go through the entire patch in detail right now.
But I did notice several places where the lines are too long, which need to get
fixed.
Comment at: lib/Headers/altivec.h:14206
Zeson marked 2 inline comments as done.
Zeson added a comment.
Hi, All.
The revision has been updated, please review it again.
Thanks a lot.
https://reviews.llvm.org/D27251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Zeson added a comment.
In https://reviews.llvm.org/D27251#610629, @kbarton wrote:
> Please make explicit the signed for the parameters to the functions you are
> changing and remove unnecessary casts. I marked the first few that I found,
> but stopped marking them after the first several.
I
Zeson updated this revision to Diff 80021.
Zeson marked 3 inline comments as done.
Zeson added a comment.
Remove some unnecessary cast
https://reviews.llvm.org/D27251
Files:
lib/Headers/altivec.h
test/CodeGen/builtins-ppc-altivec.c
test/CodeGen/builtins-ppc-p8vector.c
kbarton requested changes to this revision.
kbarton added a comment.
This revision now requires changes to proceed.
Please make explicit the signed for the parameters to the functions you are
changing and remove unnecessary casts. I marked the first few that I found, but
stopped marking them
Zeson updated this revision to Diff 79856.
Zeson added a comment.
Make vec_xst_be and vec_xl_be test cases put together seperately in
`builtins-ppc-vsx.c`
Move up macro `__VSX__` to make all vec_xst_be functions included
https://reviews.llvm.org/D27251
Files:
lib/Headers/altivec.h
jtony added inline comments.
Comment at: lib/Headers/altivec.h:16456
#ifdef __VSX__
static __inline__ vector signed long long __ATTRS_o_ai
Thanks a lot for your good catch for the macro issue in vec_xst_be, that's a
good catch. BTW, Can you move this up
Zeson added a comment.
In https://reviews.llvm.org/D27251#609014, @nemanjai wrote:
> Thank you for fixing these issues. I certainly see how the shifts really need
> to get the signedness right because the right shifts need to fill with the
> sign bit (so that vector bool will still have all 0
nemanjai added a comment.
Thank you for fixing these issues. I certainly see how the shifts really need
to get the signedness right because the right shifts need to fill with the sign
bit (so that vector bool will still have all 0 or all 1 bits). However, I don't
really follow why the
11 matches
Mail list logo
