This revision was automatically updated to reflect the committed changes.
Closed by commit rL291876: [DOXYGEN] Documentation for the newly added x86
intrinsics. (authored by kromanova).
Changed prior to commit:
https://reviews.llvm.org/D28503?vs=84038&id=84200#toc
Repository:
rL LLVM
https:
AsafBadouh added a comment.
LGTM
Comment at: emmintrin.h:1607
+///
+/// This intrinsic corresponds to the VMOVSD / MOVSD instruction.
+///
kromanova wrote:
> RKSimon wrote:
> > kromanova wrote:
> > > kromanova wrote:
> > > > kromanova wrote:
> > > > > probins
kromanova updated this revision to Diff 84038.
kromanova added a comment.
Changed the instruction name from VMOVSD to VMOVQ for _mm_loadu_si64
Repository:
rL LLVM
https://reviews.llvm.org/D28503
Files:
avxintrin.h
emmintrin.h
mmintrin.h
pmmintrin.h
xmmintrin.h
Index: xmmintrin.h
kromanova added inline comments.
Comment at: emmintrin.h:1607
+///
+/// This intrinsic corresponds to the VMOVSD / MOVSD instruction.
+///
RKSimon wrote:
> kromanova wrote:
> > kromanova wrote:
> > > kromanova wrote:
> > > > probinson wrote:
> > > > > should th
RKSimon added inline comments.
Comment at: emmintrin.h:1607
+///
+/// This intrinsic corresponds to the VMOVSD / MOVSD instruction.
+///
kromanova wrote:
> kromanova wrote:
> > kromanova wrote:
> > > probinson wrote:
> > > > should this be VMOVQ/MOVQ instead?
>
kromanova added inline comments.
Comment at: emmintrin.h:1607
+///
+/// This intrinsic corresponds to the VMOVSD / MOVSD instruction.
+///
probinson wrote:
> should this be VMOVQ/MOVQ instead?
Probably yes. Let me know if you have a different opinion.
If I us
probinson added inline comments.
Comment at: emmintrin.h:1607
+///
+/// This intrinsic corresponds to the VMOVSD / MOVSD instruction.
+///
should this be VMOVQ/MOVQ instead?
Repository:
rL LLVM
https://reviews.llvm.org/D28503
___
agutowski added a comment.
For my part, LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D28503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
m_zuckerman added a comment.
For my intrinsics ( _mm256_cvtsd_f64, _mm256_cvtsi256_si32 and
_mm256_cvtss_f32) - ** LGTM**.
Repository:
rL LLVM
https://reviews.llvm.org/D28503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l