[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

gtbercea updated this revision to Diff 105446. gtbercea added a comment. Use str() https://reviews.llvm.org/D29658 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.cpp +++

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

Hahnfeld added inline comments. Comment at: lib/Driver/Driver.cpp:564 + auto = + ToolChains[TT.str() + "/" + HostTC->getTriple().normalize()]; + if (!CudaTC) gtbercea wrote: > Hahnfeld wrote: > > The code above uses

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

gtbercea added a comment. In https://reviews.llvm.org/D29658#732520, @ABataev wrote: > Tests? Can't write any meaningful tests. This will be tested by all future patches that perform offloading using OpenMP. https://reviews.llvm.org/D29658 ___

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

gtbercea added inline comments. Comment at: lib/Driver/Driver.cpp:564 + auto = + ToolChains[TT.str() + "/" + HostTC->getTriple().normalize()]; + if (!CudaTC) Hahnfeld wrote: > The code above uses `HostTriple.str()`,

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

gtbercea updated this revision to Diff 105320. gtbercea edited the summary of this revision. gtbercea added a comment. Rebase on latest master. https://reviews.llvm.org/D29658 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

ABataev added a comment. Tests? Comment at: lib/Driver/Driver.cpp:556 else { -const ToolChain = getToolChain(C.getInputArgs(), TT); -C.addOffloadDeviceToolChain(, Action::OFK_OpenMP); +const ToolChain *TC = nullptr; +

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM with one small note Comment at: lib/Driver/Driver.cpp:564 + auto = + ToolChains[TT.str() + "/" + HostTC->getTriple().normalize()]; +

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

gtbercea updated this revision to Diff 95171. gtbercea added a comment. Remove tests which belong into a different patch. Repository: rL LLVM https://reviews.llvm.org/D29658 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

Hahnfeld added a comment. Is there a way to actually test the changed code? The current test changes seem unrelated... Comment at: include/clang/Basic/DiagnosticDriverKinds.td:165-166 "The target '%0' is not a supported OpenMP host target.">; +def

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

gtbercea updated this revision to Diff 93679. gtbercea added a comment. Herald added a subscriber: rengolin. Split patch. Repository: rL LLVM https://reviews.llvm.org/D29658 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/Driver.cpp test/OpenMP/target_messages.cpp

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

Hahnfeld requested changes to this revision. Hahnfeld added inline comments. This revision now requires changes to proceed. Comment at: lib/Frontend/CompilerInvocation.cpp:2181-2190 + if (!(TT.getArch() == llvm::Triple::ppc || +TT.getArch() ==