ABataev accepted this revision.
ABataev added a comment.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D29904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM unless Alexey still has objections
Repository:
rL LLVM
https://reviews.llvm.org/D29904
___
cfe-commits mailing list
gtbercea updated this revision to Diff 93670.
gtbercea added a comment.
run clang-format on test.
Repository:
rL LLVM
https://reviews.llvm.org/D29904
Files:
lib/Frontend/CompilerInvocation.cpp
test/OpenMP/target_parallel_no_exceptions.cpp
Index:
gtbercea marked 2 inline comments as done.
gtbercea added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:2167-2172
+// Set the flag to prevent the implementation from emitting device
exception
+// handling code for those requiring so.
+if
gtbercea updated this revision to Diff 93665.
gtbercea added a comment.
Redo regression test.
Repository:
rL LLVM
https://reviews.llvm.org/D29904
Files:
lib/Frontend/CompilerInvocation.cpp
test/OpenMP/target_parallel_no_exceptions.cpp
Index:
Hahnfeld requested changes to this revision.
Hahnfeld added a comment.
This revision now requires changes to proceed.
Out of interest: This is a limition of the implementation, right? Because the
standard only says: `A throw executed inside a target region must cause
execution to resume within
gtbercea added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:2167-2172
+// Set the flag to prevent the implementation from emitting device
exception
+// handling code for those requiring so.
+if (Opts.OpenMPIsDevice && T.isNVPTX()) {
+
gtbercea updated this revision to Diff 93513.
gtbercea added a comment.
Herald added a subscriber: rengolin.
Clean-up test.
Repository:
rL LLVM
https://reviews.llvm.org/D29904
Files:
lib/Frontend/CompilerInvocation.cpp
test/OpenMP/target_parallel_no_exceptions.cpp
Index:
ABataev added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:2167-2172
+// Set the flag to prevent the implementation from emitting device
exception
+// handling code for those requiring so.
+if (Opts.OpenMPIsDevice && T.isNVPTX()) {
+
Hahnfeld added a comment.
LGTM. Please run `clang-format` before committing!
Comment at: test/OpenMP/target_parallel_no_exceptions.cpp:6-7
+
+#define SIZE 100
+#define EPS 1e-10
+
Not needed, please keep the test as small as possible
Repository:
rL
gtbercea created this revision.
For the OpenMP toolchain which offloads to NVIDIA GPUs make sure that no
exception handling code is emitted.
Repository:
rL LLVM
https://reviews.llvm.org/D29904
Files:
lib/Frontend/CompilerInvocation.cpp
test/OpenMP/target_parallel_no_exceptions.cpp
11 matches
Mail list logo