CaseyCarter added a comment.
I also have no problem with this change.
Comment at: test/support/poisoned_hash_helper.hpp:53
using LibraryHashTypes = TypeList<
+#if !defined(TEST_WORKAROUND_C1XX_BROKEN_NULLPTR_CONVERSION_OPERATOR)
#if TEST_STD_VER > 14
I would
EricWF added a comment.
In https://reviews.llvm.org/D31260#708139, @BillyONeal wrote:
> (Though you might want something like this anyway if you try libc++ with
> MSVC++ on Windows...)
Exactly why I volunteered to do this. As libc++ and MSVC implement C++17 at
different rates I suspect we'l
BillyONeal accepted this revision.
BillyONeal added a comment.
This revision is now accepted and ready to land.
I mean, looks good to me, but you really don't need to go there :). (Though you
might want something like this anyway if you try libc++ with MSVC++ on
Windows...)
https://reviews.llv
EricWF created this revision.
This is my attempt to work around the C1XX bug described to me by @BillyONeal.
https://reviews.llvm.org/D31260
Files:
test/support/poisoned_hash_helper.hpp
test/support/test.workarounds/c1xx_broken_nullptr_conversion_operator.pass.cpp
test/support/test_macros
