[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

thakis closed this revision. thakis added a comment. Landed in r299952: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20170410/189882.html Repository: rL LLVM https://reviews.llvm.org/D31652 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier added a comment. In https://reviews.llvm.org/D31652#723664, @thakis wrote: > Looks good. Do you have commit access? Thanks! And no I don't have commit access. Repository: rL LLVM https://reviews.llvm.org/D31652 ___ cfe-commits mailing

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Looks good. Do you have commit access? Repository: rL LLVM https://reviews.llvm.org/D31652 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier added a comment. Friendly ping. Repository: rL LLVM https://reviews.llvm.org/D31652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier added a comment. Thanks for that @thakis, that's a much better solution than the first attempt! Repository: rL LLVM https://reviews.llvm.org/D31652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier updated this revision to Diff 94438. bradfier edited the summary of this revision. bradfier added a comment. Switch to a more appropriate (and much simpler) method of identifying these Java-specific operators. Also removed any references to fictitious "logical left shifts", I think I ma

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

thakis added inline comments. Comment at: include/clang/Basic/TokenKinds.def:230 +PUNCTUATOR(greatergreatergreaterequal, ">>>=") +PUNCTUATOR(lesslesslessequal, "<<<=") + I think this is the wrong approach to go about this. clang is a C compiler, and its tokenize

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier added inline comments. Comment at: include/clang/Basic/LangOptions.def:95 LANGOPT(ObjC2 , 1, 0, "Objective-C 2") +LANGOPT(Java , 1, 0, "Java") BENIGN_LANGOPT(ObjCDefaultSynthProperties , 1, 0, arphaman wrote: > I don't think we

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier added a comment. In https://reviews.llvm.org/D31652#719990, @arphaman wrote: > Are the `<<<` and `>>>` operators handled correctly? Yes, as a side-effect of CUDA kernel-call syntax which uses `>>>` and `<<<`, those tokens are recognised as punctuators. Repository: rL LLVM https:/

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

arphaman added inline comments. Comment at: include/clang/Basic/LangOptions.def:95 LANGOPT(ObjC2 , 1, 0, "Objective-C 2") +LANGOPT(Java , 1, 0, "Java") BENIGN_LANGOPT(ObjCDefaultSynthProperties , 1, 0, I don't think we should have a `Ja

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

arphaman added a comment. Are the `<<<` and `>>>` operators handled correctly? Repository: rL LLVM https://reviews.llvm.org/D31652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier updated this revision to Diff 94334. bradfier added a reviewer: klimek. bradfier added a comment. Add more diff context, add klimek as reviewer. Repository: rL LLVM https://reviews.llvm.org/D31652 Files: include/clang/Basic/LangOptions.def include/clang/Basic/TokenKinds.def li

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier created this revision. Herald added a subscriber: klimek. At present, clang-format mangles Java containing logical shift assignment operators ('>>>=' or '<<<='), splitting them in two, resulting in invalid code: public class Minimal { public void func(String args) { int i