sepavloff updated this revision to Diff 99273.
sepavloff added a comment.
Moved tooling related code into separate change https://reviews.llvm.org/D33272
https://reviews.llvm.org/D33013
Files:
include/clang/Tooling/CompilationDatabase.h
lib/Driver/Driver.cpp
sepavloff added inline comments.
Comment at: lib/Tooling/CompilationDatabase.cpp:208
IntrusiveRefCntPtr DiagOpts = new DiagnosticOptions();
- UnusedInputDiagConsumer DiagClient;
+ TextDiagnosticPrinter DiagnosticPrinter(llvm::errs(), &*DiagOpts);
+ UnusedInputDiagConsumer
alexfh added inline comments.
Comment at: lib/Tooling/CompilationDatabase.cpp:208
IntrusiveRefCntPtr DiagOpts = new DiagnosticOptions();
- UnusedInputDiagConsumer DiagClient;
+ TextDiagnosticPrinter DiagnosticPrinter(llvm::errs(), &*DiagOpts);
+ UnusedInputDiagConsumer
sepavloff updated this revision to Diff 98930.
sepavloff added a comment.
Herald added a subscriber: klimek.
Added missed case
The patch missed a case when Compilation object is created during work of
clang based tool, it resulted in fail of the test 'clang-tidy/diagnostic.cpp'.
This addition to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302775: Driver must return non-zero code on errors in
command line (authored by sepavloff).
Changed prior to commit:
https://reviews.llvm.org/D33013?vs=98395=98592#toc
Repository:
rL LLVM
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sepavloff updated this revision to Diff 98395.
sepavloff added a comment.
Addressed reviewer's notes.
https://reviews.llvm.org/D33013
Files:
lib/Driver/Driver.cpp
test/Driver/aarch64-cpus.c
test/Driver/amdgpu-features.c
test/Driver/arm-darwin-builtin.c
rsmith added a comment.
Thank you, some of these test typos are ... alarming. =)
A couple of the test updates don't look quite right, but this mostly looks
great.
Comment at: test/Driver/amdgpu-features.c:1
-// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri
sepavloff created this revision.
Herald added subscribers: krytarowski, javed.absar, nhaehnle, rengolin,
aemerson.
Now if clang driver is given wrong arguments, in some cases it
continues execution and returns zero code. This change fixes this
behavior.
The fix revealed some errors in clang
