[PATCH] D33827: [clang-tidy] misc-static-assert shouldn't flag assert(!"msg")

This revision was automatically updated to reflect the committed changes. Closed by commit rL304657: [clang-tidy] Make misc-static-assert accept assert(!"msg") (authored by fgross). Changed prior to commit: https://reviews.llvm.org/D33827?vs=101197=101311#toc Repository: rL LLVM

[PATCH] D33827: [clang-tidy] misc-static-assert shouldn't flag assert(!"msg")

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! Repository: rL LLVM https://reviews.llvm.org/D33827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33827: [clang-tidy] misc-static-assert shouldn't flag assert(!"msg")

lebedev.ri added a comment. While not directly related to this Differential, i wonder if it would make sense to also not warn on calls to (especially non-member) functions marked with `__attribute__((const))`, maybe `__attribute__((pure))` too. At least i'm not sure what side-effects such calls

[PATCH] D33827: [clang-tidy] misc-static-assert shouldn't flag assert(!"msg")

fgross created this revision. Herald added a subscriber: xazax.hun. Added negated string literals to the set of IsAlwaysFalse expressions to avoid flagging of assert(!"msg") https://reviews.llvm.org/D33827 Files: clang-tidy/misc/StaticAssertCheck.cpp