[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

yawanng added a comment. Ping https://reviews.llvm.org/D35372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

yawanng updated this revision to Diff 107557. yawanng added a comment. Refactor the check, add a base class for it, which can facilitate all other similar checks. Basically, all checks in the same category will have only one or two lines code by inheriting the base class. If this looks good, I

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

chh added a comment. If most code can be shared in a common base class like CloexecCheck, maybe all 8 "Add a close-on-exec check" CLs can be combined into 1 or 2 CLs to consolidate all review efforts. I also prefer a separate check name for each function, so users can enable/disable each check.

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

yawanng added a comment. In https://reviews.llvm.org/D35372#810525, @alexfh wrote: > In https://reviews.llvm.org/D35372#810457, @alexfh wrote: > > > I have deja vu ;) > > > > Should we make a single check for all CLOEXEC and friends with a single > > configurable list of (function name, flag

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

alexfh added a comment. In https://reviews.llvm.org/D35372#810457, @alexfh wrote: > I have deja vu ;) > > Should we make a single check for all CLOEXEC and friends with a single > configurable list of (function name, flag name) pairs? Okay, it may be a bit more complicated than just a list of

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

alexfh added a comment. I have deja vu ;) Should we make a single check for all CLOEXEC and friends with a single configurable list of (function name, flag name) pairs? https://reviews.llvm.org/D35372 ___ cfe-commits mailing list

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

yawanng updated this revision to Diff 106515. yawanng marked an inline comment as done. https://reviews.llvm.org/D35372 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecMemfdCreateCheck.cpp

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `android-cloexec-memfd_create + `_ check Please sort checks in alphabetical order.