[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

This revision was automatically updated to reflect the committed changes. Closed by commit rL312865: [Basic] Update CMakeLists.txt to handle repo (authored by MinSeongKIM). Changed prior to commit: https://reviews.llvm.org/D35533?vs=114160=114488#toc Repository: rL LLVM

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D35533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

minseong.kim updated this revision to Diff 114160. minseong.kim marked 3 inline comments as done. minseong.kim added a comment. Re-uploading the patch, removing debug messages accidentally included in the patch. https://reviews.llvm.org/D35533 Files: lib/Basic/CMakeLists.txt Index:

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

minseong.kim updated this revision to Diff 114115. minseong.kim edited the summary of this revision. minseong.kim added a reviewer: hintonda. minseong.kim removed a subscriber: hintonda. minseong.kim added a comment. I have updated the diff. https://reviews.llvm.org/D35533 Files:

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

hintonda added a comment. In https://reviews.llvm.org/D35533#862852, @minseong.kim wrote: > @hintonda, Absolutely. Incorporating @modocache's module changes into the > version in AddLLVM.cmake would solve the current version display issue for > repo and do not affect the process of other

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

minseong.kim added a comment. @hintonda, Absolutely. Incorporating @modocache's module changes into the version in AddLLVM.cmake would solve the current version display issue for repo and do not affect the process of other version control systems (e.g. git, git-svn, svn, and git submodule).

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

hintonda added a comment. I just looked into both approaches and believe the one taken in AddLLVM.cmake is correct and handles the submodule case correctly. It uses `git rev-parse --git-dir` to find the location of the actual .git directory. Please see https://reviews.llvm.org/D31985 for

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

hintonda added a comment. In https://reviews.llvm.org/D35533#862798, @minseong.kim wrote: > Hi~ @hintonda, > > Using using find_first_existing_file in ADDLLVM.cmake solves the cases with > repo in conjunction with https://reviews.llvm.org/D35532. However, I am not > sure it can handle

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

minseong.kim added a comment. Hi~ @hintonda, Using using find_first_existing_file in ADDLLVM.cmake solves the cases with repo in conjunction with https://reviews.llvm.org/D35532. However, I am not sure it can handle @modocache's git submodule cases (https://reviews.llvm.org/D34955).

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

hintonda added a comment. Now that 36971 has been committed, I believe you can just remove the `find_first_existing_file` and `find_first_existing_vc_file` macro definitions from this file. https://reviews.llvm.org/D35533 ___ cfe-commits mailing

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

minseong.kim added a comment. I have updated the description with a hope for it to be more descriptive. Kindly ping~ https://reviews.llvm.org/D35533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org