This revision was automatically updated to reflect the committed changes.
Closed by commit rL311200: [clang-diff] Move printing of matches and changes to
clang-diff (authored by krobelus).
Repository:
rL LLVM
https://reviews.llvm.org/D36179
Files:
cfe/trunk/include/clang/Tooling/ASTDiff/AST
johannes updated this revision to Diff 110945.
johannes added a comment.
format
https://reviews.llvm.org/D36179
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-basic.cpp
tools/clang-
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, with one request below:
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:96
- /// Finds an edit script that converts T1 to T2.
- std::vector computeChanges(Mapping &
johannes updated this revision to Diff 110608.
johannes added a comment.
initialize Node::Shift
https://reviews.llvm.org/D36179
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-basic.cp
arphaman added inline comments.
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:40
NodeId Parent, LeftMostDescendant, RightMostDescendant;
- int Depth, Height;
+ int Depth, Height, Shift;
ast_type_traits::DynTypedNode ASTNode;
Looks like `Shift` isn't
johannes updated this revision to Diff 110552.
johannes added a comment.
add test for 'Move' and 'Update and Move' in output
https://reviews.llvm.org/D36179
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling/ASTDiff/ASTDiff.cpp
tes
arphaman added a comment.
Previous `Move` resulted in `llvm_unreachable("TODO");`, but now it seems to be
fixed. The new output for `Move` and `UpdateMove` should be tested in a test.
https://reviews.llvm.org/D36179
___
cfe-commits mailing list
cfe
johannes updated this revision to Diff 109417.
johannes added a comment.
remove unused SubtreeIterator
https://reviews.llvm.org/D36179
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-b
