[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

twoh added a subscriber: wenlei. twoh added a comment. Herald added a subscriber: dexonsmith. Herald added a project: clang. Hello @rsmith, @wenlei and I took another look at this, and we couldn't find any use of `AnonymousTagLocations` outside of debug info. If that's actually the case, wouldn'

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

twoh added a comment. Friendly ping for comments. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38061/new/ https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

wenlei added a comment. In D38061#1484486 , @dblaikie wrote: > Seems like the right thing would be for the DWARF code that wants a rendered > type name to pass its own printing policy, rather than changing some > relatively global one. > > (though also I

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

dblaikie added a comment. Seems like the right thing would be for the DWARF code that wants a rendered type name to pass its own printing policy, rather than changing some relatively global one. (though also I have my doubts about the whole approach - macro expansion can change the line number

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

dblaikie added a comment. In D38061#1484568 , @wenlei wrote: > In D38061#1484486 , @dblaikie wrote: > > > Seems like the right thing would be for the DWARF code that wants a > > rendered type name to pass its own p

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

twoh added a comment. ping! Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

twoh updated this revision to Diff 164564. twoh edited the summary of this revision. twoh added a comment. Herald added a subscriber: cfe-commits. Addressing comments from @echristo. Reverted option name change, and added a test case. Sorry I haven't work on this code for a while so it took time

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

twoh added a comment. @rsmith @dblaikie Thank you for the comments! It seems that this is not the appropriate way to handle the issue. I'll find different way to resolve the problem. Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

echristo added a reviewer: aprantl. echristo added a comment. I think Adrian has looked at this more recently than I have. Adding him here. Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

aprantl added a comment. I have a vague recollection that this column info hack was added to disambiguate two types defined on the same line (which is something that happened more often than one would think because of macro expansion). Did you do the git archeology to ensure that the original

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

aprantl added a comment. Oh wait, this patch is just for dumping the ASTs? Can you elaborate why this makes it into a binary then? Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

aprantl added a comment. RTTI? Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

twoh added a comment. @aprantl It is a debug info. If you compile test/CodeGenCXX/debug-info-anonymous.cpp file with `clang -g2 -emit-llvm -S `, you will find debug metadata something like `distinct !DISubprogram(name: "foo", linkageName: "_Z3fooIN1XUt_EEiT_" ...`, which will eventually be inc

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

dblaikie added a comment. In https://reviews.llvm.org/D38061#1271021, @twoh wrote: > @aprantl It is a debug info. If you compile > test/CodeGenCXX/debug-info-anonymous.cpp file with `clang -g2 -emit-llvm -S > `, you will find debug metadata something like `distinct !DISubprogram(name: > "foo /

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

twoh added a comment. @dblaikie I see. The problem we're experiencing is that with Clang's naming scheme we end up having different function name between the original source and the preprocessed source (as macro expansion changes the column number). This doesn't work well for me if I want to us

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

dblaikie added a comment. In https://reviews.llvm.org/D38061#1275845, @twoh wrote: > @dblaikie I see. The problem we're experiencing is that with Clang's naming > scheme we end up having different function name between the original source > and the preprocessed source (as macro expansion change

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

rsmith requested changes to this revision. rsmith added inline comments. This revision now requires changes to proceed. Comment at: lib/Frontend/CompilerInstance.cpp:491-494 + PrintingPolicy Policy = Context->getPrintingPolicy(); + if (!getCodeGenOpts().DebugColumnInfo) +Po

Re: [PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

On Fri, Oct 19, 2018 at 3:56 PM Adrian Prantl via Phabricator via llvm-commits wrote: > aprantl added a comment. > > I have a vague recollection that this column info hack was added to > disambiguate two types defined on the same line (which is something that > happened more often than one would