[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

This revision was automatically updated to reflect the committed changes. Closed by commit rL318035: [X86] test/testn intrinsics lowering to IR. clang side (authored by uriel.k). Changed prior to commit: https://reviews.llvm.org/D38737?vs=122082&id=122639#toc Repository: rL LLVM https://rev

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

uriel.k added inline comments. Comment at: lib/Headers/avx512vlbwintrin.h:2425 + return _mm_mask_cmpneq_epi8_mask (__U, _mm_and_si128 (__A, __B), + _mm_setzero_hi()); } uriel.k wrote: > For strange reason this line moved and is n

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

uriel.k added inline comments. Comment at: lib/Headers/avx512vlbwintrin.h:2425 + return _mm_mask_cmpneq_epi8_mask (__U, _mm_and_si128 (__A, __B), + _mm_setzero_hi()); } For strange reason this line moved and is not aligned with t

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

uriel.k updated this revision to Diff 122082. uriel.k marked 2 inline comments as done. https://reviews.llvm.org/D38737 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h lib/Headers/avx512vlbwintrin.h lib/Headers/avx512vlintrin.h test/

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

craig.topper added inline comments. Comment at: lib/Headers/avx512vlbwintrin.h:2801 + return _mm_mask_cmp_epi8_mask (__U, _mm_and_si128 (__A, __B), + _mm_setzero_hi(), 4); } craig.topper wrote: > Sorry I didn't catch this before,

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

craig.topper added inline comments. Comment at: lib/Headers/avx512vlbwintrin.h:2801 + return _mm_mask_cmp_epi8_mask (__U, _mm_and_si128 (__A, __B), + _mm_setzero_hi(), 4); } Sorry I didn't catch this before, but can you use _MM_C

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

uriel.k updated this revision to Diff 121716. https://reviews.llvm.org/D38737 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h lib/Headers/avx512vlbwintrin.h lib/Headers/avx512vlintrin.h test/CodeGen/avx512bw-builtins.c test/CodeGen

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

uriel.k updated this revision to Diff 121699. uriel.k marked an inline comment as done. https://reviews.llvm.org/D38737 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h lib/Headers/avx512vlbwintrin.h lib/Headers/avx512vlintrin.h test/

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

craig.topper added inline comments. Comment at: lib/Headers/avx512bwintrin.h:2109 + return _mm512_cmp_epi8_mask(_mm512_and_epi32(__A, __B), +_mm512_setzero_qi(), 4); } Can you align this with the opening paren on the line above? Same with all th

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

uriel.k created this revision. Changed Header files of the intrinsics fro lowering test and testn intrinsics to IR code. Removed test and testn builtins from clang this is the clang side, the llvm side revision is D38736 . https://reviews.llvm.org/D38737 File