This revision was automatically updated to reflect the committed changes.
Closed by commit rL316249: [Analyzer] Correctly handle parameters passed by
reference when bodyfarming std… (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39031?vs=119415=119724#toc
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Some nits inline, but looks good to me!
Comment at: lib/Analysis/BodyFarm.cpp:388
+ // reference.
+ for (unsigned int i = 2; i < D->getNumParams(); i++) {
+
danielmarjamaki added a reviewer: danielmarjamaki.
danielmarjamaki added a comment.
Stylistically this looks pretty good to me. Just a minor nit.
Comment at: lib/Analysis/BodyFarm.cpp:389
+ for (unsigned int i = 2; i < D->getNumParams(); i++) {
+
+const ParmVarDecl *PDecl
george.karpenkov created this revision.
Herald added subscribers: szepet, kristof.beyls, xazax.hun, javed.absar,
aemerson.
Also explicitly do not support functors for now, since that entails figuring
out which call operator corresponds to the passed parameters.
Resolution: we really should not
