This revision was automatically updated to reflect the committed changes.
Closed by commit rL318925: [clangd] Drop impossible completions (unavailable or
inaccessible) (authored by sammccall).
Repository:
rL LLVM
https://reviews.llvm.org/D39836
Files:
clang-tools-extra/trunk/clangd/ClangdLS
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
sammccall updated this revision to Diff 124066.
sammccall added a comment.
Address review comments
https://reviews.llvm.org/D39836
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
cla
sammccall added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:169
+ clangd::CodeCompleteOptions CCOpts;
+ CCOpts.EnableSnippets = EnableSnippets;
+ CCOpts.IncludeIneligibleResults = IncludeIneligibleResults;
ilya-biryukov wrote:
> We should also set
ilya-biryukov added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:169
+ clangd::CodeCompleteOptions CCOpts;
+ CCOpts.EnableSnippets = EnableSnippets;
+ CCOpts.IncludeIneligibleResults = IncludeIneligibleResults;
We should also set `IncludeCodePattern
sammccall requested review of this revision.
sammccall added a comment.
PTAL - this is now optional. The results will be hidden by default, but can be
turned on with a flag.
https://reviews.llvm.org/D39836
___
cfe-commits mailing list
cfe-commits@l
sammccall updated this revision to Diff 123819.
sammccall added a comment.
(trying to resync the diff to head)
https://reviews.llvm.org/D39836
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/Clangd
sammccall updated this revision to Diff 123817.
sammccall added a comment.
This revision is now accepted and ready to land.
Add an option to allow impossible completions.
While here, remove 'helpful' constructors that take some subset of the params.
https://reviews.llvm.org/D39836
Files:
clan
sammccall added a comment.
In https://reviews.llvm.org/D39836#920977, @arphaman wrote:
> In https://reviews.llvm.org/D39836#920587, @sammccall wrote:
>
> > So I probably should have started from the other end, here :-)
> >
> > I'd really like to make the completion retrieval and ranking more flex
arphaman added a comment.
In https://reviews.llvm.org/D39836#920587, @sammccall wrote:
> So I probably should have started from the other end, here :-)
>
> I'd really like to make the completion retrieval and ranking more flexible.
> In particular
>
> - incorporating results from other sources (
sammccall added a comment.
So I probably should have started from the other end, here :-)
I'd really like to make the completion retrieval and ranking more flexible. In
particular
- incorporating results from other sources (indexes: both in-memory and
external services).
- combining more quali
arphaman added a comment.
I would prefer to make this behaviour configurable.
https://reviews.llvm.org/D39836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
This is probably one of the things that I'd like to be configurable.
In https://reviews.llvm.org/D39836#920313, @sammccall wrote:
> - they bulk up tests and debugging output
I'
klimek added a comment.
In https://reviews.llvm.org/D39836#920313, @sammccall wrote:
> In https://reviews.llvm.org/D39836#920306, @ilya-biryukov wrote:
>
> > I personally think they're useful to have anyway, and they don't add much
> > noise when they're at the end of completions list.
> > I so
sammccall added a comment.
In https://reviews.llvm.org/D39836#920306, @ilya-biryukov wrote:
> I personally think they're useful to have anyway, and they don't add much
> noise when they're at the end of completions list.
> I sometimes want to complete an item I know is there and then fix
> acc
ilya-biryukov added a subscriber: klimek.
ilya-biryukov added a comment.
I personally think they're useful to have anyway, and they don't add much noise
when they're at the end of completions list.
I sometimes want to complete an item I know is there and then fix
accessibility. Do you think they
sammccall created this revision.
(There must be some reason why https://reviews.llvm.org/D38077 didn't just do
this, but I don't get it!)
https://reviews.llvm.org/D39836
Files:
clangd/ClangdUnit.cpp
test/clangd/completion-priorities.test
test/clangd/completion-qualifiers.test
Index: tes
17 matches
Mail list logo
