[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon marked an inline comment as done. oren_ben_simhon added inline comments. Comment at: test/CodeGen/x86-cf-protection.c:1 +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s

[PATCH] D40478: Added control flow architecture protection Flag

alexfh added inline comments. Comment at: test/CodeGen/x86-cf-protection.c:1 +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s --check-prefix=RETURN +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon added inline comments. Comment at: test/CodeGen/x86-cf-protection.c:1 +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s --check-prefix=RETURN +// RUN: not %clang_cc1 -fsyntax-only -S

[PATCH] D40478: Added control flow architecture protection Flag

alexfh added inline comments. Comment at: test/CodeGen/x86-cf-protection.c:1 +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s --check-prefix=RETURN +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm

[PATCH] D40478: Added control flow architecture protection Flag

This revision was automatically updated to reflect the committed changes. Closed by commit rC322063: Added Control Flow Protection Flag (authored by orenb, committed by ). Changed prior to commit: https://reviews.llvm.org/D40478?vs=128601=129041#toc Repository: rC Clang

[PATCH] D40478: Added control flow architecture protection Flag

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D40478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon updated this revision to Diff 128601. oren_ben_simhon added a comment. Implemented comments posted until 01/04 (Thanks Craig) Repository: rL LLVM https://reviews.llvm.org/D40478 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/TargetInfo.h

[PATCH] D40478: Added control flow architecture protection Flag

craig.topper added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:501 + if (CodeGenOpts.CFProtectionReturn) { +Target.checkCFProtectionReturnSupported(getDiags()); +// Indicate that we want to instrument return control flow protection.

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon updated this revision to Diff 128143. oren_ben_simhon added a comment. Reverted clang-format whitespaces updates Repository: rL LLVM https://reviews.llvm.org/D40478 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/TargetInfo.h

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon updated this revision to Diff 128141. oren_ben_simhon added a comment. Implemented comments posted until 12/24 (Thanks Craig) Moved cf-protection attributes from function attributes to module attributes. Repository: rL LLVM https://reviews.llvm.org/D40478 Files:

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon added a comment. In https://reviews.llvm.org/D40478#962348, @craig.topper wrote: > Are we sure we want a different command line option name from gcc? From our > internal conversations with the gcc folks I thought they were suggesting that > -fcf-protection could imply a

[PATCH] D40478: Added control flow architecture protection Flag

craig.topper added a comment. Are we sure we want a different command line option name from gcc? From our internal conversations with the gcc folks I thought they were suggesting that -fcf-protection could imply a software mechanism if a hardware mechanism was not available thorugh -mibt or

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D40478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon updated this revision to Diff 127590. oren_ben_simhon added a reviewer: pcc. oren_ben_simhon added a comment. Implemented comments posted until 12/19 (Thanks Craig) Repository: rL LLVM https://reviews.llvm.org/D40478 Files: include/clang/Driver/Options.td

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon marked an inline comment as done. oren_ben_simhon added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:876 // Apply xray attributes to the function (as a string, for now) - if (D && ShouldXRayInstrumentFunction()) { + bool InstrumentXray =

[PATCH] D40478: Added control flow architecture protection Flag

craig.topper added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1737 llvm::toStringRef(CodeGenOpts.NoSignedZeros)); +FuncAttrs.addAttribute("shstk-compatible", + llvm::toStringRef(CodeGenOpts.ShstkCompatible));

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon added a comment. -mibt is currently in discussions with other compilers, any change will be uploaded to a different review. If you have more comments i will appreciate it. Repository: rL LLVM https://reviews.llvm.org/D40478 ___