This revision was automatically updated to reflect the committed changes.
Closed by commit rC323485: [Driver] Add an -fexperimental-isel driver option to
enable/disable GlobalISel. (authored by aemerson, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42276
Files:
qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D42276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aemerson updated this revision to Diff 131191.
aemerson added a comment.
I've added two kinds of warnings, one for targets which have incomplete GISel
support, and another for unsupported optimisation levels (for ARM64
-O{1,2,3,s,z}).
Repository:
rC Clang
https://reviews.llvm.org/D42276
qcolombet added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4699
+else
+ CmdArgs.push_back("-global-isel=0");
+ }
aemerson wrote:
> qcolombet wrote:
> > qcolombet wrote:
> > > I think that it would be useful to also set
aemerson added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4699
+else
+ CmdArgs.push_back("-global-isel=0");
+ }
qcolombet wrote:
> qcolombet wrote:
> > I think that it would be useful to also set -global-isel-abort=2, so that
> >
qcolombet added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4699
+else
+ CmdArgs.push_back("-global-isel=0");
+ }
I think that it would be useful to also set -global-isel-abort=2, so that users
can report problem early.
What do you
aemerson updated this revision to Diff 130530.
Repository:
rC Clang
https://reviews.llvm.org/D42276
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Clang.cpp
test/Driver/global-isel.c
Index: test/Driver/global-isel.c
aemerson created this revision.
aemerson added reviewers: qcolombet, echristo.
Herald added subscribers: kristof.beyls, rovka.
Add an -fexperimental-isel driver option to enable/disable GlobalISel.
This is a more user friendly way of enabling GlobalISel instead of doing -mllvm
-global-isel.
