This revision was automatically updated to reflect the committed changes.
Closed by commit rC324663: [analyzer] Self-debug: Dump the cores internal
state traits to the egraph. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42560
Files:
NoQ updated this revision to Diff 132042.
NoQ marked 2 inline comments as done.
NoQ added a comment.
> More debug info is always good.
I know, right?^^
> But that's all bikeshedding though
Well, it's great for me because i'd finally learn how to write programs :)
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:400
+Out << '(' << I.second << ',' << I.first << ") ";
+I.first->printPretty(Out, nullptr, PrintingPolicy(LO));
+Out << NL;
a.sidorin wrote:
> Why
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
But that's all bikeshedding though
https://reviews.llvm.org/D42560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
george.karpenkov added a comment.
looks good otherwise.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:418
+ for (auto I : NewAllocValsMap) {
+ std::pair Key = I.first;
+ SVal Value = I.second;
indent?
actually, an even better
a.sidorin added a comment.
More debug info is always good.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:400
+Out << '(' << I.second << ',' << I.first << ") ";
+I.first->printPretty(Out, nullptr, PrintingPolicy(LO));
+Out << NL;
NoQ updated this revision to Diff 132010.
NoQ added a comment.
Address comments :)
https://reviews.llvm.org/D42560
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
include/clang/StaticAnalyzer/Core/PathSensitive/SubEngine.h
lib/StaticAnalyzer/Core/ExprEngine.cpp
george.karpenkov added a comment.
Looks good
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:392
+
+auto InitTempSet = State->get();
+if (!InitTempSet.isEmpty()) {
Actually I would put both of those into static functions:
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
When viewing the `ExplodedGraph` through graphviz, make `ExprEngine`'s two
private program state traits - namely C++ allocator values and
