yaxunl added a comment.
ping
https://reviews.llvm.org/D43783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
Hi Sam,
Sorry for the delay. LGTM, I have only minor refactoring suggestion.
Thanks,
Alexey
Comment at: lib/CodeGen/CGBlocks.cpp:1065-1067
+ llvm::Value *FuncPtr;
+ if (!
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1065-1067
+ llvm::Value *FuncPtr;
+ if (!CGM.getLangOpts().OpenCL) {
bader wrote:
> I think it would be more readable if we merge this if statement with the if
> statement at the line #1103.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326937: [OpenCL] Remove block invoke function from emitted
block literal struct (authored by yaxunl, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D43783
Files:
lib/CodeGen/CGBlocks.
yaxunl created this revision.
yaxunl added reviewers: b-sumner, Anastasia, bader.
Herald added a subscriber: nhaehnle.
OpenCL runtime tracks the invoke function emitted for
any block expression. Due to restrictions on blocks in
OpenCL (v2.0 s6.12.5), it is always possible to know the
block invoke
Anastasia added a comment.
Ping! Do you still plan to do this? :)
Repository:
rC Clang
https://reviews.llvm.org/D43783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
In https://reviews.llvm.org/D43783#1235090, @Anastasia wrote:
> Ping! Do you still plan to do this? :)
Sorry I caught up in something else. Since there are some subsequent commits,
it may take some efforts to revert it.
Repository:
rC Clang
https://reviews.llvm.org
Anastasia added a comment.
In https://reviews.llvm.org/D43783#1235126, @yaxunl wrote:
> In https://reviews.llvm.org/D43783#1235090, @Anastasia wrote:
>
> > Ping! Do you still plan to do this? :)
>
>
> Sorry I caught up in something else. Since there are some subsequent commits,
> it may take som
svenvh added a comment.
Reverted in r343582, test added in r343583.
Repository:
rC Clang
https://reviews.llvm.org/D43783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
svenvh added a comment.
Sorry for digging up an old commit...
Apparently this broke block arguments, e.g. the following test case:
int foo(int (^ bl)(void)) {
return bl();
}
int get21() {
return foo(^{return 21;});
}
int get42() {
return foo(^{return 42;});
}
In pa
yaxunl added a comment.
Herald added a subscriber: jvesely.
In https://reviews.llvm.org/D43783#1204353, @svenvh wrote:
> Sorry for digging up an old commit...
>
> Apparently this broke block arguments, e.g. the following test case:
>
> int foo(int (^ bl)(void)) {
> return bl();
> }
>
>
Anastasia added a comment.
In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote:
> In https://reviews.llvm.org/D43783#1204353, @svenvh wrote:
>
> > Sorry for digging up an old commit...
> >
> > Apparently this broke block arguments, e.g. the following test case:
> >
> > int foo(int (^ bl)(
yaxunl added a comment.
In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote:
> In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote:
> >
> > > Sorry for digging up an old commit...
> > >
> > > Apparently this broke blo
Anastasia added a comment.
In https://reviews.llvm.org/D43783#1272001, @AlexeySotkin wrote:
> In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote:
>
> > In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote:
> >
> > > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote:
> > >
>
AlexeySotkin added a comment.
In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote:
> In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote:
> >
> > > Sorry for digging up an old commit...
> > >
> > > Apparently this bro
15 matches
Mail list logo
